-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async: Started Async Porting #22
Open
MeNsaaH
wants to merge
7
commits into
master
Choose a base branch
from
async-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeNsaaH
commented
Apr 3, 2020
MeNsaaH
force-pushed
the
async-support
branch
6 times, most recently
from
April 6, 2020 18:05
8ba1d74
to
9e039d5
Compare
MeNsaaH
force-pushed
the
master
branch
6 times, most recently
from
May 25, 2020 10:45
76ef7ab
to
94585eb
Compare
MeNsaaH
force-pushed
the
master
branch
2 times, most recently
from
June 1, 2020 11:09
14db7e9
to
65ccc94
Compare
Should we close this? @deven96 |
Yeah screw this for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use colly's
Async(true)
to make scrapers run on different goroutines to improve performance.