Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce tree view for interception scripts (with common scripts support) #1590

Closed
yuriyz opened this issue Apr 1, 2019 · 8 comments
Closed

Introduce tree view for interception scripts (with common scripts support) #1590

yuriyz opened this issue Apr 1, 2019 · 8 comments
Assignees
@syntrydy
Labels
enhancement libs update, re-factroring, etc. High Priority Needs Documentation Issue that requires documentation to be added in Gluu docs Needs QA
Milestone
4.0

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Apr 1, 2019

Describe the issue

We should introduce tree view for interception scripts:

image

oxCore ticket: GluuFederation/oxCore#124

Steps To Reproduce

New Feature
@yuriyz yuriyz added this to the 4.1 milestone Apr 1, 2019
@yuriyz yuriyz added enhancement libs update, re-factroring, etc. High Priority labels Apr 1, 2019
@yuriyz yuriyz mentioned this issue Apr 1, 2019
Open
syntrydy added a commit that referenced this issue Aug 10, 2019
@syntrydy
Introduce tree view for interception scripts (with common scripts sup…
6aa69a5 
…port) #1590
syntrydy added a commit that referenced this issue Aug 10, 2019
@syntrydy
Introduce tree view for interception scripts (with common scripts sup…
3b22658 
…port) #1590
@syntrydy
Copy link
Collaborator

image

@syntrydy
Copy link
Collaborator

image

@syntrydy
Copy link
Collaborator

@yuriyz i think we can put it in 4.0. The part about common folder can be done in 4.1

@willow9886
Copy link
Contributor

Looks pretty good. Couple ux things..

  • add a space between custom and script in the add new custom script button

  • instead of green with blue highlight for the menu, let's try white with green highlight

@willow9886 willow9886 reopened this Aug 10, 2019
syntrydy added a commit that referenced this issue Aug 11, 2019
@syntrydy
https://github.com/GluuFederation/oxTrust/issues/1590
a1912e0
@syntrydy syntrydy modified the milestones: 4.1, 4.0 Aug 12, 2019
syntrydy added a commit that referenced this issue Aug 12, 2019
@syntrydy
Introduce tree view for interception scripts (with common scripts sup…
7260ebd 
…port) #1590
syntrydy added a commit that referenced this issue Aug 12, 2019
@syntrydy
Introduce tree view for interception scripts (with common scripts sup…
958db90 
…port) #1590
@syntrydy
Copy link
Collaborator

image

@syntrydy
Copy link
Collaborator

I'm merging this to 4.0 because it is working very well and it is fast compared to the previous version.

syntrydy added a commit that referenced this issue Aug 12, 2019
@syntrydy
Merge pull request #1766 from /issues/1590
24216de 
Ox trust/issues/1590
@syntrydy syntrydy added Needs Documentation Issue that requires documentation to be added in Gluu docs Needs QA labels Aug 12, 2019
@yuriyz
Copy link
Contributor Author

yuriyz commented Aug 12, 2019

@yuriyz i think we can put it in 4.0. The part about common folder can be done in 4.1

Yes, agreed. We can add common support once it's ready on back-end.

@willow9886
Copy link
Contributor

nice, looks good @syntrydy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syntrydy syntrydy

Labels
enhancement libs update, re-factroring, etc. High Priority Needs Documentation Issue that requires documentation to be added in Gluu docs Needs QA
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@yuriyz @willow9886 @syntrydy