Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Common/Universal scripts support to interpreter for python code reusing #124

Open
yuriyz opened this issue Apr 1, 2019 · 4 comments
Assignees

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Apr 1, 2019

Introduce Common/Universal scripts support to interpreter for python code reusing.

We need to introduce sharable/common scripts. To make it flexible and allow share scripts between one script type (e.g. only between Person Authentication) as well as between all script types. To make it easy to use we need :

  1. re-design our current oxTrust representation to tree
  2. introduce common types to python service, so it correctly loads them.

image

oxTrust: GluuFederation/oxTrust#1590

@yurem
Copy link
Contributor

yurem commented Oct 4, 2019

I offer to start from small steps to make script simpler:

  1. Reusable python libs
  2. Context objects
  3. Same session variables in scripts.
    These 3 steps should make script smaller and allow us to merge them.

Next steps:

  1. Identify which script we need to use in wizard
  2. Write wizard

Also updates to API should not break old scripts. We can deprecated older API in CE 5.0

@yuriyz
Copy link
Contributor Author

yuriyz commented Oct 5, 2019

I like these 3 steps. Re: wizard, we should think on some generic approach to generate wizard UI.
For developer it means:

  • provide script template
  • provide parameters (name and type) that should be used in template

With this information we should be able to generate wizard UI.

For admin it means :

  • enter parameters in wizard UI -> render script.

@jgomer2001
Copy link
Contributor

jgomer2001 commented Oct 25, 2019

@yuriyz I've compiled a list of frequently used idioms in person authentication custom scripts:
commons.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants