Return 401 if client is null in RESOURCE_OWNER_PASSWORD_CREDENTIALS

GluuFederation · Nov 16, 2015 · 6ac19e0 · 6ac19e0
1 parent 3b2e7ab
commit 6ac19e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Server/conf/oxauth-config.json b/Server/conf/oxauth-config.json
@@ -200,8 +200,8 @@
     "clientAuthenticationFilters":[
         {
             "filter":"myCustomAttr1={0}",
-            "bind":"${config.oxauth.authentication.filter.bindDn}",
-            "bindPasswordAttribute":"${config.oxauth.authentication.filter.bindPassword}",
+            "bind":false,
+            "bindPasswordAttribute":"oxAuthClientSecret",
             "baseDn":"ou=clients,o=${config.oxauth.organization},o=gluu"
         }
     ],

diff --git a/Server/src/main/java/org/xdi/oxauth/token/ws/rs/TokenRestWebServiceImpl.java b/Server/src/main/java/org/xdi/oxauth/token/ws/rs/TokenRestWebServiceImpl.java
@@ -207,10 +207,10 @@ public Response requestAccessToken(String grantType, String code,
                             scope,
                             idToken));
                 } else if (gt == GrantType.RESOURCE_OWNER_PASSWORD_CREDENTIALS) {
-//    				if (client == null) {
-//    					return sendResponse(error(401, TokenErrorResponseType.INVALID_CLIENT));
-//    				}
-//
+    				if (client == null) {
+    					return sendResponse(error(401, TokenErrorResponseType.INVALID_CLIENT));
+    				}
+
                     User user = null;
                     if (authenticationFilterService.isEnabled()) {
                         String userDn = authenticationFilterService.processAuthenticationFilters(request.getParameterMap());