fix: ensure uri has no colon #265

GluuFederation · Nov 13, 2023 · d478f10 · d478f10
1 parent ba5818d
commit d478f10
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/src/main/java/org/gluu/casa/plugins/authnmethod/service/otp/HOTPAlgorithmService.java b/app/src/main/java/org/gluu/casa/plugins/authnmethod/service/otp/HOTPAlgorithmService.java
@@ -46,7 +46,7 @@ public String generateSecretKeyUri(byte[] secretKey, String displayName) {
         String secretKeyBase32 = BaseEncoding.base32().omitPadding().encode(secretKey);
         OTPKey otpKey = new OTPKey(secretKeyBase32, OTPType.HOTP);
 
-        OTPAuthURIBuilder uribe = OTPAuthURIBuilder.fromKey(otpKey).label(displayName);
+        OTPAuthURIBuilder uribe = OTPAuthURIBuilder.fromKey(otpKey).label(displayName.replace(':', ' '));
         uribe = uribe.issuer(issuer).digits(conf.getDigits());
 
         logger.trace("Generating secret key URI");

diff --git a/app/src/main/java/org/gluu/casa/plugins/authnmethod/service/otp/TOTPAlgorithmService.java b/app/src/main/java/org/gluu/casa/plugins/authnmethod/service/otp/TOTPAlgorithmService.java
@@ -48,7 +48,7 @@ public String generateSecretKeyUri(byte[] secretKey, String displayName) {
         String secretKeyBase32 = BaseEncoding.base32().omitPadding().encode(secretKey);
         OTPKey otpKey = new OTPKey(secretKeyBase32, OTPType.TOTP);
 
-        OTPAuthURIBuilder uribe = OTPAuthURIBuilder.fromKey(otpKey).label(displayName);
+        OTPAuthURIBuilder uribe = OTPAuthURIBuilder.fromKey(otpKey).label(displayName.replace(':', ' '));
         uribe = uribe.issuer(issuer).digits(conf.getDigits());
         uribe = uribe.timeStep(TimeUnit.SECONDS.toMillis(conf.getTimeStep()));