fix room password

changelog.md

@@ -1,6 +1,9 @@
 ## v1.4.3
 
 * Fix crash on ARM MacOS when a player with an animated name is online
+* Fix rare crash with devtools
+* Add error message when entering wrong room password
+* Minor UI changes
 
 ## v1.4.2
 

src/net/manager.cpp

@@ -100,9 +100,24 @@ class PacketListenerPool : public CCObject {
  bool invoked = false;
  auto& lsm = listeners[id];
 
+ // reorder them based on priority
+ std::sort(lsm.begin(), lsm.end(), [](auto& l1, auto& l2) -> bool {
+ auto r1 = l1.lock();
+ auto r2 = l2.lock();
+
+ if (!r1) return false;
+ if (!r2) return true;
+
+ return r1->priority < r2->priority;
+ });
+
  for (auto& listener : lsm) {
  if (auto l = listener.lock()) {
  l->invokeCallback(packet);
+
+ if (l->isFinal) {
+ break;
+ }
  }
  }
  }
@@ -581,7 +596,8 @@ class NetworkManager::Impl {
  if (packet->wasInvalid) reason = "Room doesn't exist";
  if (packet->wasProtected) reason = "Room password is wrong";
  if (packet->wasFull) reason = "Room is full";
- if (!packet->wasProtected) ErrorQueues::get().error(fmt::format("Failed to join room: {}", reason)); //TEMPORARY disable wrong password alerts
+
+ ErrorQueues::get().error(fmt::format("Failed to join room: {}", reason));
  });
 
  // Admin packets

src/ui/menu/room/room_join_popup.cpp

@@ -53,7 +53,7 @@ bool RoomJoinPopup::setup() {
  this->onClose(nullptr);
  });
  }
- });
+ }, -123456789, true);
 
  nm.addListener<RoomJoinedPacket>(this, [this](std::shared_ptr<RoomJoinedPacket> packet) {
  this->onClose(nullptr);