Support for nuget package with multiple Roslyn version analyzers

src/NuGetForUnity/Editor/NugetAssetPostprocessor.cs

@@ -36,6 +36,16 @@ public class NugetAssetPostprocessor : AssetPostprocessor
  /// </summary>
  private const string AnalyzersFolderName = "analyzers";
 
+ /// <summary>
+ /// Folder of root before the version of analyzers was split.
+ /// </summary>
+ private static readonly string AnalyzersRoslynVersionsFolderName = JoinPathComponents(AnalyzersFolderName, "dotnet");
+
+ /// <summary>
+ /// Prefix for roslyn versioning of dll asset path.
+ /// </summary>
+ private static readonly string AnalyzersRoslynVersionSubFolderPrefix = JoinPathComponents(AnalyzersRoslynVersionsFolderName, "roslyn");
+
  /// <summary>
  /// Used to mark an asset as already processed by this class.
  /// </summary>
@@ -142,7 +152,7 @@ internal static void OnPostprocessAllAssets(
 
  if (assetPathComponents.Length > 1 && assetPathComponents[1].Equals(AnalyzersFolderName, StringComparison.OrdinalIgnoreCase))
  {
- ModifyImportSettingsOfRoslynAnalyzer(plugin, reimport);
+ ModifyImportSettingsOfRoslynAnalyzer(plugin, assetPathComponents, reimport);
  yield return ("RoslynAnalyzer", projectRelativeAssetPath, ResultStatus.Success);
 
  yield break;
@@ -163,6 +173,12 @@ private static string[] GetPathComponents([NotNull] string path)
  return path.Split(Path.DirectorySeparatorChar);
  }
 
+ [NotNull]
+ private static string JoinPathComponents([NotNull] params string[] pathComponents)
+ {
+ return string.Join(Path.DirectorySeparatorChar.ToString(), pathComponents);
+ }
+
  private static bool AssetIsDllInsideNuGetRepository([NotNull] string absoluteAssetPath, [NotNull] string absoluteRepositoryPath)
  {
  return absoluteAssetPath.StartsWith(absoluteRepositoryPath, PathHelper.PathComparisonType) &&
@@ -180,7 +196,21 @@ private static string GetNuGetRepositoryPath()
  return ConfigurationManager.NugetConfigFile.RepositoryPath + Path.DirectorySeparatorChar;
  }
 
- private static void ModifyImportSettingsOfRoslynAnalyzer([NotNull] PluginImporter plugin, bool reimport)
+ [CanBeNull]
+ private static string GetRoslynVersionNumberFromAnalyzerPath(string analyzerAssetPath)
+ {
+ var versionPrefixIndex = analyzerAssetPath.IndexOf(AnalyzersRoslynVersionSubFolderPrefix, StringComparison.Ordinal);
+ if (versionPrefixIndex < 0)
+ {
+ return null;
+ }
+
+ return analyzerAssetPath.Substring(versionPrefixIndex + AnalyzersRoslynVersionSubFolderPrefix.Length)
+ .Split(Path.DirectorySeparatorChar)
+ .First();
+ }
+
+ private static void ModifyImportSettingsOfRoslynAnalyzer([NotNull] PluginImporter plugin, string[] relativeRepositoryPathComponents, bool reimport)
  {
  plugin.SetCompatibleWithAnyPlatform(false);
  plugin.SetCompatibleWithEditor(false);
@@ -191,6 +221,44 @@ private static void ModifyImportSettingsOfRoslynAnalyzer([NotNull] PluginImporte
 
  AssetDatabase.SetLabels(plugin, new[] { RoslynAnalyzerLabel, ProcessedLabel });
 
+ // The nuget package can contain analyzers for multiple Roslyn versions.
+ // In that case, for the same package, the most recent version must be chosen out of those available for the current Unity version.
+ var assetRoslynVersion = GetRoslynVersionNumberFromAnalyzerPath(plugin.assetPath);
+ if (assetRoslynVersion != null)
+ {
+ var versionPrefixIndex = plugin.assetPath.IndexOf(AnalyzersRoslynVersionsFolderName, StringComparison.Ordinal);
+ var analyzersVersionsRoot = JoinPathComponents(plugin.assetPath.Substring(0, versionPrefixIndex), AnalyzersRoslynVersionsFolderName);
+ var analyzersFolders = AssetDatabase.GetSubFolders(analyzersVersionsRoot);
+
+ var enabledRoslynVersions = analyzersFolders
+ .Select(GetRoslynVersionNumberFromAnalyzerPath)
+ .Where(ver =>
+ {
+ if (ver == null)
+ {
+ return false;
+ }
+#if UNITY_2022_3_OR_NEWER && !UNITY_2022_3_1 && !UNITY_2022_3_2 && !UNITY_2022_3_3 && !UNITY_2022_3_3 && !UNITY_2022_3_4 && !UNITY_2022_3_5 && !UNITY_2022_3_6 && !UNITY_2022_3_7 && !UNITY_2022_3_8 && !UNITY_2022_3_9 && !UNITY_2022_3_10 && !UNITY_2022_3_11
+ return string.CompareOrdinal(ver, "4.3.0") <= 0;
+#elif UNITY_2022_2_OR_NEWER
+ return string.CompareOrdinal(ver, "4.1.0") <= 0;
+#elif UNITY_2021_2_OR_NEWER
+ return string.CompareOrdinal(ver, "3.8.0") <= 0;
+#else
+ return false;
+#endif
+ })
+ .ToArray();
+
+ // If most recent valid analyzers exist elsewhere, remove label `RoslynAnalyzer`
+ if (!enabledRoslynVersions.Contains(assetRoslynVersion) ||
+ string.CompareOrdinal(assetRoslynVersion, enabledRoslynVersions.Max()) < 0)
+ {
+ AssetDatabase.SetLabels(plugin, new[] { ProcessedLabel });
+ }
+ }
+
+
  if (reimport)
  {
  // Persist and reload the change to the meta file