Made packages.config path configurable from NuGet preferences #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the user manually entered an invalid path in NuGet.config file
igor84
requested changes
Aug 5, 2023
igor84
reviewed
Aug 6, 2023
igor84
reviewed
Aug 6, 2023
Comment on lines
46
to
47
| relativeTo = Path.GetFullPath(relativeTo); | ||
| path = Path.GetFullPath(path); |
There was a problem hiding this comment.
This function should probably only accept full paths and not call GetFullPath on them. If someone passed relative paths to it this would not work correctly if called from CLI version since CurrentDirectory and project path set through the argument could be different. We could throw or return path if Path.IsPathRooted returned false for any of them.
There was a problem hiding this comment.
The CLI can use Directory.SetCurrentDirectory(projectPath); to get the same behavior.
JoC0de
requested changes
Aug 6, 2023
igor84
reviewed
Aug 6, 2023
|
@popara96 i will fix the CLI soon. |
…nfig file's directory by default
popara96
commented
Aug 7, 2023
popara96
commented
Aug 7, 2023
JoC0de
requested changes
Aug 8, 2023
…fig file path is outside of Assets instead of logging
igor84
approved these changes
Aug 9, 2023
JoC0de
reviewed
Aug 9, 2023
JoC0de
requested changes
Aug 9, 2023
JoC0de
requested changes
Aug 11, 2023
|
Thank you for the thorough review @JoC0de ! |
|
Thank you for the improvement @popara96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes in order to make
packages.configpath configurable. We don't allow for the path to be outside ofAssetsfolder since we still needOnPostprocessAllAssetsto be triggered if this file is changed.