This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add gym stop pics for monocle alternate (POC) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1174,7 +1179,7 @@ function setupPokestopMarker(item) { | |||
| } | |||
|
|
|||
| marker.infoWindow = new google.maps.InfoWindow({ | |||
| content: pokestopLabel(item['lure_expiration'], item['latitude'], item['longitude'], item['pokestop_name']), | |||
| content: pokestopLabel(item['lure_expiration'], item['latitude'], item['longitude'], item['pokestop_name'], item['pokestop_url']), | |||
There was a problem hiding this comment.
This will most likely break others scanners if they dont store this in the same way. Need to have a conditional for alt otherwise you will get undefined errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for how to add pokestop and gym icons to PMSF.
POC, because i think there should be a button to enable/disable this option.
Also this is very data intensive, because it will load all pics right on start of map.
(would be better, if it would only load the specific pic if you click on the specific gym or stop)