Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ready for studio migration #39

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Make ready for studio migration #39

merged 2 commits into from
Jan 12, 2023

Conversation

aminlatifi
Copy link
Member

Upgrade subgraph dependencies
Do some initialization required by a new version of subgraph packages
Renamed xdai network to gnosis

@aminlatifi
Upgrade subgraph dependencies
627984e 
Do some initialization required by new version of subgraph packages
@aminlatifi
Copy link
Member Author

aminlatifi commented Jan 11, 2023 •
edited
Loading

Deployed to studio - not published yet and publicly not available to be seen

https://thegraph.com/studio/subgraph/giveth-staging---gnosis-chain/playground

@aminlatifi aminlatifi requested review from mateodaza and mohammadranjbarz and removed request for mateodaza January 11, 2023 19:05
@aminlatifi
Copy link
Member Author

#38

mohammadranjbarz
mohammadranjbarz requested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is bunch of xdai terms in our codes, maybe it's better to change them to gnosis, WDYT?(generated files and CI/cD have xdai in them, if you search xdai in project you would see)

Screen Shot 1401-10-22 at 11 40 01

Screen Shot 1401-10-22 at 11 39 44

@aminlatifi
Copy link
Member Author

There is bunch of xdai terms in our codes, maybe it's better to change them to gnosis, WDYT?(generated files and CI/cD have xdai in them, if you search xdai in project you would see)

Screen Shot 1401-10-22 at 11 40 01 Screen Shot 1401-10-22 at 11 39 44

@mohammadranjbarz You are right, just pushed the update

mohammadranjbarz
mohammadranjbarz approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aminlatifi LGTM

@aminlatifi aminlatifi merged commit 319bc14 into develop Jan 12, 2023
@aminlatifi aminlatifi deleted the feat/subgraph_studio_support branch January 12, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadranjbarz mohammadranjbarz mohammadranjbarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminlatifi @mohammadranjbarz