Fix marking gix-packetline-blocking
copy auto-generated
#1690
+7
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c957ab8 (#1340), I intended to mark the contents of
gix-packetline-blocking/src
as auto-generated for github-linguist, but I did not do so correctly, because giving the directory as a path does not specify thelinguist-generated
attribute as being unset for the contents.This fixes that. The bug, and fix, is revealed by comparing the output of
github-linguist --breakdown
before and after this:(The test was done on Ubuntu 18.04 LTS ESM with
github-linguist
provided by theruby-github-linguist
package, version 5.3.3-1.)In addition to fixing that, this also simplifies
.gitattributes
files throughout the repository. This simplification includes removing redundantclrf=input
(discussed in #1676) and a spurious unrecognized-eof
(see #1689), changing lone**
to*
where equivalent, and some other changes.This also makes the style of
.gitattributes
files more consistent, usingfoo
/-foo
rather thanfoo=true
/foo=false
everywhere even where both work, and using whitespace more consistently.Regarding the use of
-linguist-vendored
instead oflinguist-vendored=false
, maybe that will get fixture shell scripts recognized as non-vendored in the language breakdown at the gitee mirror. The language breakdown at the Codeberg mirror already recognizes them. Both seem to usegithub-linguist
.However, the motivation for the change is more stylistic consistency, and I doubt this will affect the language breakdown on gitee. I have tested with 7.9.0 (as well as even earlier versions, as above), and both forms seem to be recognized, though it seems there is a separate 7.9.0_gitee version, which I haven't tested with. The language is just shown as Rust if I fork gitoxide on gitee.
I mainly mention the mirrors in connection with Codeberg: that doesn't need fixing, but if this is merged and if, once the Codeberg mirror is updated, the language breakdown is correctly shown on both GitHub and Codeberg, then that will confirm the changes here, at least in the fix to
linguist-generated
, are working.