Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

448 coda transformations data closure #457

Merged
merged 4 commits into from
Nov 15, 2024
Merged

448 coda transformations data closure #457

merged 4 commits into from
Nov 15, 2024

Conversation

jtlait
Copy link
Collaborator

@jtlait jtlait commented Nov 13, 2024

I reverted back to @em-t code and I also slightly altered closure check to be either closure of 1 and 100 as other cases should be very rare.

nmaarnio
nmaarnio approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@nmaarnio nmaarnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmaarnio nmaarnio merged commit 3f80048 into master Nov 15, 2024
4 checks passed
@jtlait jtlait mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmaarnio nmaarnio nmaarnio approved these changes

@chudasama-bijal chudasama-bijal Awaiting requested review from chudasama-bijal

@msorvoja msorvoja Awaiting requested review from msorvoja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtlait @nmaarnio