338 agterberg cheng ci test #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 6, 2024 14:10
|
@jtpesone and @chudasama-bijal , have you had time to look at this and #355 ? I am busy with other EIS issues and would like to avoid having to wrap up these Wofe issues. |
|
At this stage it should be sufficient to provide the Agterberg-Cheng CI test, implementation seems good to go. |
|
Okay thanks @chudasama-bijal , then I'll proceed to merge this! |
nmaarnio
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #338
I opened this as a draft at this point, since I would like some feedback before finalizing things.
Is it doing what it's supposed to? 😄
Are there any other CI tests to include? (Eg. the sources listed in the issue mention chi-squared test and the Kolmogorov-Smirnov test. Chi-squared is already included in the toolkit, but I don't know how well it integrates with the data types used by the WofE functions, and I didn't look into the latter at all.)
What would be a useful output from the function?