Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search radius parameter to IDW interpolation #292

Merged

Conversation

msorvoja
Copy link
Contributor

@msorvoja msorvoja commented Dec 2, 2024

Fixes #289

GispoCoding/eis_toolkit#471 needs to be merged first in the toolkit.

@msorvoja msorvoja requested a review from nmaarnio December 2, 2024 11:32
@msorvoja msorvoja linked an issue Dec 2, 2024 that may be closed by this pull request
@msorvoja msorvoja force-pushed the 289-add-search-radius-parameter-to-idw-interpolation branch from 847d272 to 882268b Compare December 4, 2024 13:10
Copy link
Collaborator

@nmaarnio nmaarnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing.

I realized when reviewing this PR that opening any proxy processing view will mess up the plugin size. It cannot be resized to smaller anymore afterwards, because the proxy processing pages lack scroll widgets 🤯 let's take care of that issue in a separate PR, however.

@@ -52,6 +52,7 @@ def __init__(self,
self.interpolation_method: QComboBox
self.interpolation_method_pages: QComboBox
self.power: QgsDoubleSpinBox
self.search_radius: QgsDoubleSpinBox
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max value seemed to be 99 when I tested this in Wizard. Could set maxValue something like 99999, should be enough

@nmaarnio nmaarnio merged commit e9fc720 into master Dec 5, 2024
2 checks passed
@nmaarnio nmaarnio deleted the 289-add-search-radius-parameter-to-idw-interpolation branch December 5, 2024 07:41
msorvoja added a commit that referenced this pull request Jan 7, 2025
* feat(IDW): Add search radius parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search radius parameter to IDW interpolation
2 participants