Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save location of custom mineral systems #287

Conversation

nmaarnio
Copy link
Collaborator

@nmaarnio nmaarnio commented Nov 27, 2024

Changed the save location of custom / user-defined mineral system JSONs from a directory under the plugin to a directory under the QGIS profile the user is using. This should fix the unwanted behavior where custom mineral system JSONs get wiped out when updating / reinstalling the plugin.

Unfortunately the custom mineral systems users have defined right now need to be exported manually and imported back after the next release of EIS QGIS Plugin. Automated migration is not possible because the migration code would run only after updating the plugin, when the mineral system JSONs are lost already 🙁

…ored to avoid loss when updating, add path util funcs
@nmaarnio nmaarnio requested a review from msorvoja November 27, 2024 07:42
@nmaarnio nmaarnio added bug Something isn't working Wizard Feature/issue related to EIS QGIS Wizard labels Nov 27, 2024
Copy link
Contributor

@msorvoja msorvoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work as it should.

@nmaarnio nmaarnio merged commit d3092bc into master Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Wizard Feature/issue related to EIS QGIS Wizard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Imported custom mineral systems get deleted when plugin is installed/updated
2 participants