Remove long package name handling #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing test case where plugin tools in used with a processing provider
Since we have extended approved line length to 120 it is unlikely that imports should be reformatted. For example with that one conditional formatting the package name could be 38 chars long before alternative formatting should occur. This should be a rare case and it's okay to let a user to fix that.
LKajan
force-pushed
the
remove-long-package-name-handling
branch
from
ed60ac8 to
ba3030b
Compare
JuhoErvasti
approved these changes
Jun 14, 2024
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR:
Since we have extended the approved line length to 120 it is unlikely that imports should be reformatted. For example with that one conditional formatting the package name could be 38 chars long before alternative formatting should occur. This should be a rare case and it's okay to let a user to fix that.
Contains also few small not related fixes.
Resolves #19 by leaving the possible issue to user to resolve