Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tick marks to plots #792

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrewdsen
Copy link

Provides functionality for tick marks (issue #328).

  • Tick marks are toggled with the theme keyword tick_color.
  • Tick marks are drawn over grid lines and have the same line width as grid lines.
  • Tick mark length is set to 1% of the maximum axis length. (It would be easy to allow user definition via theme if that functionality is desired).

These look best when panel_stroke is defined. On that note, I also added a line width for the panel stroke (set to theme.line_width). This doesn't seem to affect things in the SVG but it makes a big difference in appearance in PDF rendering, where the panel line width is somewhat chunky.

I should note that the dynamic behavior in the SVG output is somewhat broken, in my opinion: ticks move when the window is panned but only the original tick marks are retained (none appear to be generated when zooming). Not sure what to change to remedy this.

@bjarthur
Copy link
Member

@andrewdsen can you please rebase this PR with master? i'd like to try out tick marks. thanks.

@Mattriks
Copy link
Member

also now #1047. Perhaps time to create a new branch, and modify/update the code in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants