-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Density geometry revamp #1157
Open
tlnagy
wants to merge
14
commits into
master
Choose a base branch
from
tn/density-revamp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4b3c4f2 - Browse repository at this point
Copy the full SHA 4b3c4f2View commit details -
[WIP] prelim version of the density geometry revamp
working on #1152. Note: This is a WIP and currently completely breaks `Geom.density` and `Geom.violin` has several regressions.
Configuration menu - View commit details
-
Copy full SHA for 944fc29 - Browse repository at this point
Copy the full SHA 944fc29View commit details -
preserve insertion order when grouping
this is necessary for allowing user control over ordering in stacked density plots
Configuration menu - View commit details
-
Copy full SHA for ca168c3 - Browse repository at this point
Copy the full SHA ca168c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2462e - Browse repository at this point
Copy the full SHA 6b2462eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d278888 - Browse repository at this point
Copy the full SHA d278888View commit details -
try to be less clever and add ability to stack densities
My original implementation was too clever in that it figured out the orientation of density and violin plots automatically. The logic ended up being quite convoluted and so I switched back to using the standard `orientation` logic and an explicit flag for whether a density plot is a violin or not. This commit also adds the ability to stack either raw densities and to create conditional density distributions.
Configuration menu - View commit details
-
Copy full SHA for 978bc4a - Browse repository at this point
Copy the full SHA 978bc4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 084bb29 - Browse repository at this point
Copy the full SHA 084bb29View commit details -
move default values from densitystat to respective geoms
There are no set of defaults that apply to both density and violin geometries so it's better if they each have their respective defaults
Configuration menu - View commit details
-
Copy full SHA for 29022de - Browse repository at this point
Copy the full SHA 29022deView commit details -
get density estimation to a functional state
Simple KDEs should now be working
Configuration menu - View commit details
-
Copy full SHA for 0f90c44 - Browse repository at this point
Copy the full SHA 0f90c44View commit details -
- adds support for horizontal violins - removes manual control over splitting (temp until position code is rewritten)
Configuration menu - View commit details
-
Copy full SHA for 3e9617c - Browse repository at this point
Copy the full SHA 3e9617cView commit details
Commits on Jun 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d3c77ac - Browse repository at this point
Copy the full SHA d3c77acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55e4ff8 - Browse repository at this point
Copy the full SHA 55e4ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6b2104 - Browse repository at this point
Copy the full SHA c6b2104View commit details -
Configuration menu - View commit details
-
Copy full SHA for 229b9fd - Browse repository at this point
Copy the full SHA 229b9fdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.