Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Density geometry revamp #1157

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[WIP] Density geometry revamp #1157

wants to merge 14 commits into from

Commits on Jun 3, 2018

  1. Configuration menu
    Copy the full SHA
    4b3c4f2 View commit details
    Browse the repository at this point in the history
  2. [WIP] prelim version of the density geometry revamp

    working on #1152.
    
    Note: This is a WIP and currently completely breaks `Geom.density` and
    `Geom.violin` has several regressions.
    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    944fc29 View commit details
    Browse the repository at this point in the history
  3. preserve insertion order when grouping

    this is necessary for allowing user control over ordering in stacked
    density plots
    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    ca168c3 View commit details
    Browse the repository at this point in the history
  4. update doctests for groupby

    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    6b2462e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d278888 View commit details
    Browse the repository at this point in the history
  6. try to be less clever and add ability to stack densities

    My original implementation was too clever in that it figured out the
    orientation of density and violin plots automatically. The logic ended
    up being quite convoluted and so I switched back to using the standard
    `orientation` logic and an explicit flag for whether a density plot is a
    violin or not.
    
    This commit also adds the ability to stack either raw densities and to
    create conditional density distributions.
    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    978bc4a View commit details
    Browse the repository at this point in the history
  7. fix for missed renaming

    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    084bb29 View commit details
    Browse the repository at this point in the history
  8. move default values from densitystat to respective geoms

    There are no set of defaults that apply to both density and violin
    geometries so it's better if they each have their respective defaults
    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    29022de View commit details
    Browse the repository at this point in the history
  9. get density estimation to a functional state

    Simple KDEs should now be working
    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    0f90c44 View commit details
    Browse the repository at this point in the history
  10. fix up violin render()

    - adds support for horizontal violins
    - removes manual control over splitting (temp until position code is
    rewritten)
    tlnagy committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    3e9617c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2018

  1. fix bandwidth setting example

    tlnagy committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    d3c77ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55e4ff8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c6b2104 View commit details
    Browse the repository at this point in the history
  4. update news

    [ci skip]
    tlnagy committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    229b9fd View commit details
    Browse the repository at this point in the history