Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRごとにをデバッグサーバーを立ち上げるときのinitContainersにmod-downloaderを追加 #1414

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

rito528
Copy link
Member

@rito528 rito528 commented Nov 16, 2023

#1397 (review)

この返信を参考に、PRごとにデバッグサーバーを立ち上げる部分のinitContainerにmod-downloaderを追加しました

@rito528 rito528 requested a review from outductor November 16, 2023 14:08
@rito528 rito528 changed the title prごとniinitContainersにmod-downloaderを追加 PRごとにをデバッグサーバーを立ち上げるときのinitContainersにmod-downloaderを追加 Nov 16, 2023
@outductor outductor requested a review from kory33 November 17, 2023 02:41
kory33
kory33 previously approved these changes Nov 18, 2023
Copy link
Member

@kory33 kory33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

一点だけ!

Copy link
Member

@kory33 kory33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kory33 kory33 merged commit 1ace1f0 into main Nov 18, 2023
2 checks passed
@kory33 kory33 deleted the feat/add-mod-downloader-on-debug-pr branch November 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants