Update to Lucene 4.8 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et into feature/lucene-48
stevetemple
requested review from
a user,
aheaford,
g-dove,
jdurcan,
lukehook,
ThomasAdams2 and
tristanjthompson
lukehook
approved these changes
Nov 23, 2021
tristanjthompson
approved these changes
Nov 24, 2021
Comment on lines
+104
to
+115
| { | ||
| var docSet = queryFilter.GetDocIdSet(leaf.AtomicReader.AtomicContext, leaf.AtomicReader.LiveDocs); | ||
| if (docSet == null) | ||
| { | ||
| continue; | ||
| } | ||
| var iterator = docSet.GetIterator(); | ||
| if (iterator == null) | ||
| { | ||
| continue; | ||
| } | ||
| bitsQueryWithoutFacetDrilldown.InPlaceOr(iterator); |
There was a problem hiding this comment.
Formatting has gone a bit astray here
Suggested change
| { | |
| var docSet = queryFilter.GetDocIdSet(leaf.AtomicReader.AtomicContext, leaf.AtomicReader.LiveDocs); | |
| if (docSet == null) | |
| { | |
| continue; | |
| } | |
| var iterator = docSet.GetIterator(); | |
| if (iterator == null) | |
| { | |
| continue; | |
| } | |
| bitsQueryWithoutFacetDrilldown.InPlaceOr(iterator); | |
| { | |
| var docSet = queryFilter.GetDocIdSet(leaf.AtomicReader.AtomicContext, leaf.AtomicReader.LiveDocs); | |
| if (docSet == null) | |
| { | |
| continue; | |
| } | |
| var iterator = docSet.GetIterator(); | |
| if (iterator == null) | |
| { | |
| continue; | |
| } | |
| bitsQueryWithoutFacetDrilldown.InPlaceOr(iterator); |
Comment on lines
+33
to
+35
| if (cnt >= _facetSearcherConfiguration.MinimumCountInTotalDatasetForFacet) | ||
| yield return new FacetSearcher.FacetValues.FacetValueBitSet | ||
| { Value = termReader.Term.Utf8ToString(), Bitset = bitset, Count = cnt }; |
There was a problem hiding this comment.
Feels a bit weird not having braces here?
Suggested change
| if (cnt >= _facetSearcherConfiguration.MinimumCountInTotalDatasetForFacet) | |
| yield return new FacetSearcher.FacetValues.FacetValueBitSet | |
| { Value = termReader.Term.Utf8ToString(), Bitset = bitset, Count = cnt }; | |
| if (cnt >= _facetSearcherConfiguration.MinimumCountInTotalDatasetForFacet) | |
| { | |
| yield return new FacetSearcher.FacetValues.FacetValueBitSet | |
| { Value = termReader.Term.Utf8ToString(), Bitset = bitset, Count = cnt }; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version for Lucene.net 4.8