Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing attribute and typo in VideoRoomCreateParams #141

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: missing attribute and typo in VideoRoomCreateParams #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jarust_plugins/examples/video_room.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ async fn main() -> anyhow::Result<()> {
.publish(
VideoRoomPublishParams {
audiocodec: Some(VideoRoomAudioCodec::OPUS),
videocoded: Some(VideoRoomVideoCodec::H264),
videocodec: Some(VideoRoomVideoCodec::H264),
bitrate: Some(3500),
descriptions: Some(vec![VideoRoomPublishDescription {
mid: String::from("stream-0"),
Expand Down
6 changes: 5 additions & 1 deletion jarust_plugins/src/video_room/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ impl_tryfrom_serde_value!(VideoRoomAllowedAction);
make_dto!(
VideoRoomCreateParams,
optional {
/// Can be configured in plugin settings. If set, rooms can be created via API only if this key is provided in the request
admin_key: String,
/// Room ID, chosen by plugin if missing
room: JanusId,
/// whether the room should be saved in the config file, default=false
Expand Down Expand Up @@ -327,7 +329,7 @@ make_dto!(
/// audio codec to prefer among the negotiated ones
audiocodec: VideoRoomAudioCodec,
/// video codec to prefer among the negotiated ones
videocoded: VideoRoomVideoCodec,
videocodec: VideoRoomVideoCodec,
/// bitrate cap to return via REMB
/// overrides the global room value if present
bitrate: u64,
Expand Down Expand Up @@ -420,6 +422,8 @@ make_dto!(VideoRoomRtpForwardParams,
streams: Vec<VideoRoomRtpForwardStream>
},
optional {
/// If `lock_rtp_forward` is set in the plugin settings, the `admin_key` (also configured in plugin settings) has to be supplied with RTP forwarding requests
admin_key: String,
/// length of authentication tag (32 or 80)
host_family: String,
/// length of authentication tag (32 or 80)
Expand Down
Loading