Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split incoming/outgoing packet registry, transition protocol states correctly #841

Merged
merged 58 commits into from
Oct 8, 2024
Merged

Split incoming/outgoing packet registry, transition protocol states correctly #841

merged 58 commits into from
Oct 8, 2024

Commits on Jul 20, 2024

  1. Initial code changes

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    b6a7b0a View commit details
    Browse the repository at this point in the history

  2. Make it compile

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    0d18334 View commit details
    Browse the repository at this point in the history

  3. Small inlining

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    9f10790 View commit details
    Browse the repository at this point in the history

  4. Make less detectable by anticheats and fix keepalive during configura… 

    …tion
    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    def403a View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Fix keepalive edge case

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    f2d67ef View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Properly switch inbound protocol in server listener

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e33042c View commit details
    Browse the repository at this point in the history

  2. Add flow control

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1341744 View commit details
    Browse the repository at this point in the history

  3. Make toggling automatic keepalive work in another way

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fccce03 View commit details
    Browse the repository at this point in the history

  4. Remove ping pong packets again

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a7e539f View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Address review

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    2b310d2 View commit details
    Browse the repository at this point in the history

  2. Handle keepalive in configuration

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    72721b8 View commit details
    Browse the repository at this point in the history

  3. Only spawn keepalive after login is acknowledged

    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    576b311 View commit details
    Browse the repository at this point in the history

  4. Prevent very unlikely race conditions with keepalive being switched d… 

    …uring a task
    @AlexProgrammerDE
    AlexProgrammerDE committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    68a426d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Add debug log for packet serialization and state switching

    @AlexProgrammerDE
    AlexProgrammerDE committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2ae3b2f View commit details
    Browse the repository at this point in the history

  2. Add one more debug print

    @AlexProgrammerDE
    AlexProgrammerDE committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5d90ce1 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Update protocol/src/main/java/org/geysermc/mcprotocollib/network/Sess… 

    …ion.java

Co-authored-by: chris <[email protected]>
    @AlexProgrammerDE @onebeastchris
    AlexProgrammerDE and onebeastchris authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2439c69 View commit details
    Browse the repository at this point in the history

  2. Update protocol/src/main/java/org/geysermc/mcprotocollib/protocol/Min… 

    …ecraftProtocol.java

Co-authored-by: chris <[email protected]>
    @AlexProgrammerDE @onebeastchris
    AlexProgrammerDE and onebeastchris authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    087e644 View commit details
    Browse the repository at this point in the history

  3. Update protocol/src/main/java/org/geysermc/mcprotocollib/protocol/Min… 

    …ecraftProtocol.java

Co-authored-by: chris <[email protected]>
    @AlexProgrammerDE @onebeastchris
    AlexProgrammerDE and onebeastchris authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    608b03d View commit details
    Browse the repository at this point in the history

  4. Mark packet as nonnull

    @AlexProgrammerDE
    AlexProgrammerDE committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b54a21b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/splitting-v3' into splitting-v3

    @AlexProgrammerDE
    AlexProgrammerDE committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    618c0b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Fix outbound writing race conditions

    @AlexProgrammerDE
    AlexProgrammerDE committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    324f066 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Ensure packets are always sent on the event loop 

    This replicates the same approach Mojang uses in their networking code.
    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0ff09d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge remote-tracking branch 'upstream/master' into splitting-v3 

    # Conflicts:
#	protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/TcpClientSession.java
    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b58eb3a View commit details
    Browse the repository at this point in the history

  2. Reduce log verbosity

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8bafb95 View commit details
    Browse the repository at this point in the history

  3. Put errors into debug

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a19d1d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Update protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/… 

    …TcpClientSession.java

Co-authored-by: chris <[email protected]>
    @AlexProgrammerDE @onebeastchris
    AlexProgrammerDE and onebeastchris authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c838e00 View commit details
    Browse the repository at this point in the history

  2. Add comment to always running in event loop

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    611cd8e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/splitting-v3' into splitting-v3

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ef81342 View commit details
    Browse the repository at this point in the history

  4. Handle auto read earlier to prevent race conditions

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b67d76c View commit details
    Browse the repository at this point in the history

  5. Make instance dynamic

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7f8affb View commit details
    Browse the repository at this point in the history

  6. Revert "Make instance dynamic" 

    This reverts commit 7f8affb.
    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3111bd1 View commit details
    Browse the repository at this point in the history

  7. Make flush packet priority

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9706bb3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Do not hide original line that is the cause of the exception

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d4eddfa View commit details
    Browse the repository at this point in the history

  2. Cancel packet using exception rather than return

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6507e77 View commit details
    Browse the repository at this point in the history

  3. Properly iterate through parents

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4e2b64d View commit details
    Browse the repository at this point in the history

  4. Set log level to debug for unit tests

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e82133d View commit details
    Browse the repository at this point in the history

  5. Revert "Properly iterate through parents" 

    This reverts commit 4e2b64d.
    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    54228e5 View commit details
    Browse the repository at this point in the history

  6. Revert "Cancel packet using exception rather than return" 

    This reverts commit 6507e77.
    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c57de2a View commit details
    Browse the repository at this point in the history

  7. Add write length filter

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d84ce87 View commit details
    Browse the repository at this point in the history

  8. Reuse bytebuf for fake flush to avoid unnecessary allocations

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    793dfae View commit details
    Browse the repository at this point in the history

  9. Make tests happy

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    187e2c5 View commit details
    Browse the repository at this point in the history

  10. Remake dropping packets

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    615cec8 View commit details
    Browse the repository at this point in the history

  11. Update protocol/src/main/java/org/geysermc/mcprotocollib/network/tcp/… 

    …TcpServer.java

Co-authored-by: chris <[email protected]>
    @AlexProgrammerDE @onebeastchris
    AlexProgrammerDE and onebeastchris authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    792519a View commit details
    Browse the repository at this point in the history

  12. Fix space

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a12a952 View commit details
    Browse the repository at this point in the history

  13. Rename to flush packet

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f9b86e5 View commit details
    Browse the repository at this point in the history

  14. Add mojmap reference

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0b28bf7 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Share keepalive code

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e4976d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge remote-tracking branch 'upstream/master' into splitting-v3

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6cee7c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge remote-tracking branch 'upstream/master' into splitting-v3 

    # Conflicts:
#	protocol/src/main/java/org/geysermc/mcprotocollib/protocol/ClientListener.java
#	protocol/src/main/java/org/geysermc/mcprotocollib/protocol/ServerListener.java
    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9a576e0 View commit details
    Browse the repository at this point in the history

  2. Fix compilation

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fc868b6 View commit details
    Browse the repository at this point in the history

  3. Revert a tiny bit closer to vanilla

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    59fcdf1 View commit details
    Browse the repository at this point in the history

  4. Inline lambda

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    549170a View commit details
    Browse the repository at this point in the history

  5. Inherit annotation

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8f85079 View commit details
    Browse the repository at this point in the history

  6. Inherit annotation 2

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f3d32cd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Use checkerframework annotation

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ae1e7ed View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fixup grammar slightly

    @AlexProgrammerDE
    AlexProgrammerDE authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f72438b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Add reset states method

    @AlexProgrammerDE
    AlexProgrammerDE committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c36d179 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add log marker for packet logging

    @AlexProgrammerDE
    AlexProgrammerDE committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5090ca4 View commit details
    Browse the repository at this point in the history