-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new message action list and reaction selector UI #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
…e into new-message-action-list-ui
isekovanic
reviewed
Oct 8, 2024
isekovanic
reviewed
Oct 8, 2024
isekovanic
reviewed
Oct 8, 2024
isekovanic
reviewed
Oct 8, 2024
isekovanic
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR introduces a new message menu, removing the previous
MessageOverlay
.The new components, as per the diagram, are introduced:
🛠 Implementation details
MessageActionList
,MessageActionListItem
,MessageOverlay
,messageTextNumberOfLines
,OverlayReactions
,OverlayReactionsAvatar
,OverlayReactionsItem
from theOverlayProvider
and add them to Channel component throughMessagesContext
.The message Menu is brought down the hierarchy, so we removed the message overlay context completely.
setData
,setOverlay
,onLongPress
,onPress
, andonPressIn
prop from Message.tsx. The last three are removed in favour of similar props on MessagesContext and are, therefore, not needed. ThesetData
,setOverlay
props are removed as we removed the message overlay context and theoverlay
prop in overlay context accepts 'alert' | 'gallery' | 'none' now on. TheMessageOverlay
prop is introduced.useMessageActions
hook doesn’t takesetOverlay
anymore but takes indismissOverlay
.dismissOverlay
. The definition ofshowMessageOverlay
is changed to(showMessageReactions?: boolean) => void;
.isMessageActionsVisible
is changed toshowMessageReactions
inmessageAction.ts
.error
,isMyMessage
,isThreadMessage
,message
, andmessageReactions
props fromOverlayContext
.Also fixes #1734
☑️ Checklist
develop
branch