fix: replace binarySearchByDateEqualOrNearestGreater with findIndexInSortedArray \w midpoint match #1370
+254
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… binarySearchByDateEqualOrNearestGreater
arnautov-anton
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
MartinCupela and
myandrienko
as code owners
|
Size Change: -343 B (-0.08%) Total Size: 427 kB
|
arnautov-anton
commented
Sep 19, 2024
test/unit/channel_state.js
Outdated
Comment on lines
113
to
114
| expect(state.messages[7].id).to.be.equal('id'); | ||
| expect(state.messages[8].id).to.be.equal('7'); |
There was a problem hiding this comment.
One hurdle of the midpoint check addition is that message with the same created_at will be added before existing one but since the existence of the messages with the same created_at in real-world applications is almost impossible - I adjusted the test.
Even without midpoint check, the previous solution - in case of multiple messages with the same created_at - the new message would be placed at most one index after the already existing one which is still incorrect.
arnautov-anton
commented
Sep 19, 2024
Comment on lines
-2694
to
-2712
| describe('', () => { | ||
| const messages = [ | ||
| { created_at: '2024-08-05T08:55:00.199808Z', id: '0' }, | ||
| { created_at: '2024-08-05T08:55:01.199808Z', id: '1' }, | ||
| { created_at: '2024-08-05T08:55:02.199808Z', id: '2' }, | ||
| { created_at: '2024-08-05T08:55:03.199808Z', id: '3' }, | ||
| { created_at: '2024-08-05T08:55:04.199808Z', id: '4' }, | ||
| { created_at: '2024-08-05T08:55:05.199808Z', id: '5' }, | ||
| { created_at: '2024-08-05T08:55:06.199808Z', id: '6' }, | ||
| { created_at: '2024-08-05T08:55:07.199808Z', id: '7' }, | ||
| { created_at: '2024-08-05T08:55:08.199808Z', id: '8' }, | ||
| ]; | ||
| it('finds the nearest newer item', () => { | ||
| expect(binarySearchByDateEqualOrNearestGreater(messages, new Date('2024-08-05T08:55:02.299808Z'))).to.eql(3); | ||
| }); | ||
| it('finds the nearest matching item', () => { | ||
| expect(binarySearchByDateEqualOrNearestGreater(messages, new Date('2024-08-05T08:55:07.199808Z'))).to.eql(7); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Moved to utils.test.ts with additions.
arnautov-anton
force-pushed
the
fix/find-index-in-sorted-array-midpoint-match
branch
from
398af35
to
544753a
Compare
arnautov-anton
commented
Sep 19, 2024
Comment on lines
95
to
+106
| it("updates an existing message that wasn't filtered due to changed timestamp (timestampChanged)", () => { | ||
| const newMessage = getNewFormattedMessage({ timeOffset: 30 * 1000, id: messagesBefore[4].id }); | ||
| const newMessage = getNewFormattedMessage({ timeOffset: 30 * 1000, id: messagesBefore[3].id }); | ||
|
|
||
| expect(messagesBefore[4].id).to.equal(newMessage.id); | ||
| expect(messagesBefore[4].text).to.not.equal(newMessage.text); | ||
| expect(messagesBefore[4]).to.not.equal(newMessage); | ||
| expect(messagesBefore[3].id).to.equal(newMessage.id); | ||
| expect(messagesBefore[3].text).to.not.equal(newMessage.text); | ||
| expect(messagesBefore[3]).to.not.equal(newMessage); | ||
|
|
||
| const messagesAfter = addToMessageList(messagesBefore, newMessage, false, 'created_at', false); | ||
| const messagesAfter = addToMessageList(messagesBefore, newMessage, false); | ||
|
|
||
| expect(messagesAfter).to.have.length(5); | ||
| expect(messagesAfter[4]).to.equal(newMessage); | ||
| expect(messagesAfter[3]).to.equal(newMessage); | ||
| }); |
There was a problem hiding this comment.
I messed up here previously.
arnautov-anton
changed the title
MartinCupela
force-pushed
the
fix/find-index-in-sorted-array-midpoint-match
branch
from
efd7c38
to
d009882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes and replaces
binarySearchByDateEqualOrNearestGreaterwith universalfindIndexInSortedArrayfunction and enables exact matching by checking midpoint.Changes to
channelandchannel_statetests are to ensure proper order of generated messages (addedcreated_atto each generated message with proper offset).