CVE-2007-4559 Patch

[TrellixVulnTeam]

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

[vapier]

this is likely something we want to fix, but we don't use GH to track changes. please see our docs:
https://github.com/GerritCodeReview/git-repo/blob/main/SUBMITTING_PATCHES.md

[JanneKiiskila]

Not sure that's very helpful, as it's still pointing in this repo. I think @vapier is trying to say to use this repo as the origin;

https://gerrit.googlesource.com/git-repo

The on in GitHub is just a mirror.

[vapier]

the fact the docs live in this repo is irrelevant. it specifically has a Sending your patches section that explains where to send things. you can clone the repo from github and still send the patches to googlesource.com, like the docs explain.

[andersonguermo]

Ousado

[timscharfenort8]

good