Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localSettings.ts #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thomasmagninfeysot
Copy link

No description provided.

@@ -91,7 +91,7 @@ async function homepageLocaleSettingsAdapter(
href: '/map/observation/landscape',
images: [
{
thumbnail: '/medias/placeholder3.jpg',
thumbnail: '/medias/placeholder4.jpg',
Copy link
Member

@submarcos submarcos Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change ? there is no placeholder4.jpg file in /public/medias folder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est moi, c'est pas la bonne photo qui est appelé sur la page d'accueil pour les éléments paysagers :
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomaspnrhj en effet nous étions dans l'attente de ton retour pour nous communiquer des descriptions et images à mettre par défaut.

Si tu fais cette modification il faut aussi ajouter une image placeholder4 dans le dossier public/medias

@thomasmagninfeysot
Copy link
Author

Oui on avait transféré des images à Tim, elle est déjà dans medias, c'est juste le code qui n'appelle pas la bonne

@submarcos
Copy link
Member

@thomaspnrhj Elle a du se perdre car elle n'y est pas : https://github.com/Georiviere/Georiviere-public/tree/main/public/medias

@thomasmagninfeysot
Copy link
Author

Si besoin : placeholder4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants