Small fixes to run this code in 2023 #22
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the code is still maintained but here are several small fixes I introduced to try and run it without CGAL bindings. Putting them here if it can help.
As the libraries versions are not fixed, I stumbled upon compatibilities issues with newer versions of them.
np.bool
since1.24.0
. I replaced it withbool
as it seemsnp.bool
was only an alias on Pythonbool
type.geoms
to iterate over themcascaded_union
is deprecated and will soon be replaced byunary_union
I also added two checks to prevent what seem to me as unnecessary breaking exceptions:
compute_shape()
infit.py
I noticed that when @Geodan/concave-hull returns an invalid polygon (it does happen from time to time) the union will break. Added a check to prevent merging alpha shape geometry with invalid concave-hull geometrytriangle_geometry()
inalpha_shape.py
I encountered some cases wheresqrt()
had to deal with a very small negative number. I added atry: ... except ValueError: ...
around it and initialized the area value to0