Sanitize user input #187
Closed
Sanitize user input #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A malicious user may be able to forge new log entries or may access unexpected resources.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Philippluca
requested changes
May 3, 2024
Comment on lines
7
to
33
| public void SanitizeFileNameForValidFileNames() | ||
| { | ||
| AssertSanitizeFileName("SQUIRRELGENESIS", "SQUIRRELGENESIS"); | ||
| AssertSanitizeFileName("JUNIORARK.xyz", "JUNIORARK.xyz"); | ||
| AssertSanitizeFileName("PEEVEDBEAM-ANT.MESS.abc", "PEEVEDBEAM-ANT.MESS.abc"); | ||
| AssertSanitizeFileName("WEIRD WATER.example", "WEIRD WATER.example"); | ||
| AssertSanitizeFileName("AUTOFIRE123.doc", "AUTOFIRE123.doc"); | ||
| AssertSanitizeFileName("SUNNY(1).doc", "SUNNY(1).doc"); | ||
| AssertSanitizeFileName("ODD_MONKEY.doc", "ODD_MONKEY.doc"); | ||
| AssertSanitizeFileName("SILLY,MONKEY.docx", "SILLY,MONKEY.docx"); | ||
| AssertSanitizeFileName("CamelCase.bat", "CamelCase.bat"); | ||
| AssertSanitizeFileName("SLICKER-CHIPMUNK.bat", "SLICKER-CHIPMUNK.bat"); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void SanitizeFileNameForInvalidFileNames() | ||
| { | ||
| AssertSanitizeFileName("CHIPMUNKWALK", " CHIPMUNKWALK "); | ||
| AssertSanitizeFileName("SLEEPYBOUNCE", "SLEEPYBOUNCE\n"); | ||
| AssertSanitizeFileName("PLOWARK", "PLOWARK\r"); | ||
| AssertSanitizeFileName("JUNIORGLEE", "JUNIORGLEE\t"); | ||
| AssertSanitizeFileName("LATENTROUTE34", "LATENTROUTE?34"); | ||
| AssertSanitizeFileName("TRAWLSOUFFLE", "TRAWLSOUFFLE*"); | ||
| AssertSanitizeFileName("VIOLENTIRON", "><VIOLENTIRON\"|"); | ||
| AssertSanitizeFileName("YELLOWBAGEL", "YELLOWBAGEL://"); | ||
| AssertSanitizeFileName("ZANYWATER", "ZANYWATER$"); | ||
| } |
There was a problem hiding this comment.
REQ: Tests als DataRows umsetzten. So werden gleich alle tests ausgeführt auch wenn einer davon fehlschlägt.
There was a problem hiding this comment.
PP: Die gefixten Alerts mit Nr. Verlinken
There was a problem hiding this comment.
Wart noch kurz mit dem Review... Bin nur CodeQL am Testen 😅
danjov
previously approved these changes
May 3, 2024
| /// <summary> | ||
| /// GeoPilot API extensions. | ||
| /// </summary> | ||
| public static class Extensions |
There was a problem hiding this comment.
PP: Umbenenn zu StringExtensions, da diese Klasse genau das beinhaltet.
There was a problem hiding this comment.
Danke! Wartet bitte noch mit dem Review... ich schliesse diesen hier wieder 😅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some CodeQL code scanning alerts.