Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GWC-1293] Upgrade junit from 4.12 to 4.13.2 #1294

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sikeoka
Copy link
Contributor

@sikeoka sikeoka commented Jul 18, 2024

#1293
This is just a test dependency upgrade.
org.junit.Assert.assertThat is deprecated and had to be converted to org.hamcrest.MatcherAssert.assertThat.
org.junit.rules.ExpectedException is deprecated and had to be converted to org.junit.Assert.assertThrows.

@sikeoka

This comment was marked as resolved.

@sikeoka sikeoka force-pushed the GWC-1293 branch 3 times, most recently from f3eb556 to 70facf5 Compare July 25, 2024 17:04
@sikeoka
Copy link
Contributor Author

sikeoka commented Jul 25, 2024

This PR replaces #885

Copy link
Member

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for going through all the changes needed for the upgrade

@aaime aaime merged commit bd66f04 into GeoWebCache:main Jul 30, 2024
7 checks passed
@sikeoka sikeoka deleted the GWC-1293 branch August 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants