Skip to content

Commit

Permalink
Allow building with QA on Java 17+
Browse files Browse the repository at this point in the history
Running `mvn ... -Dqa` with Java 17/21 breaks errorprone.

Fixed with:

* Update errorProne.version:2.18.0 -> 2.24.1
* Add `geowebcache/.mvn/jvm.config` with the required `--add-exports`
for the `maven-compiler-plugin` as explained at https://errorprone.info/docs/installation#jdk-16.
  • Loading branch information
groldan committed Jan 5, 2024
1 parent a08b64f commit 9ad063d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions geowebcache/.mvn/jvm.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED
2 changes: 1 addition & 1 deletion geowebcache/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<jackson.databind.version>2.15.2</jackson.databind.version>
<jetty.version>9.4.33.v20201020</jetty.version>
<errorProneFlags></errorProneFlags>
<errorProne.version>2.18.0</errorProne.version>
<errorProne.version>2.24.1</errorProne.version>
<javac.version>9+181-r4173-1</javac.version>
<pmd.version>6.55.0</pmd.version>
<checkstyle.skip>false</checkstyle.skip>
Expand Down

0 comments on commit 9ad063d

Please sign in to comment.