Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12763] 3D tiles geometricError mandatory field should be on tileset level #12764

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

mattiagiupponi
Copy link
Contributor

ref #12763

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi self-assigned this Dec 2, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 2, 2024
@mattiagiupponi mattiagiupponi marked this pull request as ready for review December 2, 2024 11:22
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (0b792cf) to head (bd73434).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12764      +/-   ##
==========================================
- Coverage   67.00%   67.00%   -0.01%     
==========================================
  Files         952      952              
  Lines       56911    56911              
  Branches     6725     6725              
==========================================
- Hits        38135    38133       -2     
- Misses      17165    17166       +1     
- Partials     1611     1612       +1     

@giohappy giohappy modified the milestone: 4.4.2 Dec 2, 2024
@giohappy giohappy merged commit eb35218 into master Dec 2, 2024
17 checks passed
@giohappy giohappy deleted the ISSUE_12763 branch December 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D tiles geometricError mandatory field should be on tileset level
2 participants