Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kills combat_fancy and replaces it with some HEAVY METAL #1098

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

kittysmooch
Copy link

About The Pull Request

nukes combat_fancy.ogg because im tired of ppl complaining abt it
adds combat_HEAVY_METAL.ogg
sets the default cmode_music to pick from a list of tracks. this means having cmode_music on your class is now a debuff because you don't get varied music tracks

Why It's Good For The Game

idk im ngl i set musicpower to 0 ages ago. this track rules tho

@kittysmooch
Copy link
Author

image
lol

@radarseas
Copy link

honestly, I'd just let people pick what combat music they want, with classes/antag status only setting the default combat tunes.

vamped mercs might like their own theme combat music more for example, rebels might prefer something else, etc.

@kittysmooch
Copy link
Author

honestly, I'd just let people pick what combat music they want, with classes/antag status only setting the default combat tunes.

vamped mercs might like their own theme combat music more for example, rebels might prefer something else, etc.

great idea but technically out of scope since the real point was to kill combat_fancy so ppl stop complaining abt it. pick your own combat music is probably pretty easy but then i'd have to ponder which combat music tracks live or die because the list is actually pretty bloated. and. i don wanna

@feliniddotexe
Copy link

feliniddotexe commented Dec 27, 2024

i'm not sure this track rly fits well, especially for nobility

combat_HEAVY_METAL.mp4

@kittysmooch
Copy link
Author

half the tracks in use right now are mid electronica with some acoustic instrumental samples lets be real here

@YeCrowbarLamb
Copy link

didn't the combat music get changed anyways? it's different now

@HeroWithYay
Copy link

HeroWithYay commented Dec 28, 2024

didn't the combat music get changed anyways? it's different now

It did get changed, but its some awful jester-music...
So removal is very welcome, the new track single-handedly made me turn off music

@radarseas
Copy link

tbh I'd make Beethoven Virus (this: https://www.youtube.com/watch?v=DtKCNJmARF0) the noble combat tune. Its far better a song than whatever piano midi we have.

@Hemlock32
Copy link

half the tracks in use right now are mid electronica with some acoustic instrumental samples lets be real here

This is something to fix, not, something to make worse

@Lutowski
Copy link
Collaborator

remove heavy metal (from the list but keep the file) we're not peak yet

@kittysmooch
Copy link
Author

remove heavy metal (from the list but keep the file) we're not peak yet

done 👍

@Lutowski Lutowski merged commit db15f54 into GeneralPantsuIsBadAtCoding:main Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants