Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microdosing debloat: ports item_equipped_movement_rustle from tg and uses it to clean up armor rustles, ports collars #1097

Conversation

kittysmooch
Copy link

About The Pull Request

i set out to port some ratwood stuff by request of like five different people and found out that our system for making clothing go jingle jangle, like with chain shirts, is actually pretty buggy and not suited for task. it was built out of the squeak component for tg clown shoes, which really wasn't meant to do this sort of thing. to fix this i ported a relatively new component from tg that's more performant and more powerful. it allows us to define a wider variety of sounds and gives us more control over how loud those sounds are, how far they can be heard, how frequently they play, and allows us to attach it to basically anything that we want to make sounds on step.

using this new component, i:

  • cleaned up some now unnecessary vars that were being applied to clothing and armor
  • changed how armor rustles work a little bit. they're now a little less loud and play a little less often, which should make up for hearing more of them and make playing armor classes a little less fatiguing on your ears
  • added armor rustles to some variants of armored legs
  • added a jingly bell sound to jester shoes and hats
  • finally actually did the requested port of the collar and bell collar from Ratwood, adding crafting recipes for everything involved and putting them as loadout options.
  • reorganized the armor.dm so like objects go together
  • re-childed some blacksteel items so theyd get armor rustles too
  • organized the saiga.dm file a little bit. i was initially going to add sleigh bells for them that worked like ian dressup on tg, but had to punt that feature down the line because the squeak component wasn't friendly to this application.

jingly bell sounds used under license and accredited in a .txt. collar sprites were originally by daemoninsideme. credit to kevak for the original pr i was initially porting.

Why It's Good For The Game

less shitcode, more goodcode 👍
gay features for gay players 👍

@ChillyLobster
Copy link

On one hand: loadout collar fetish code

On the other hand: MY fetishcode jingly jester hats

@kittysmooch
Copy link
Author

rubbing my hands together and smiling like mister the grinch. if i couch my fetishcode in a high quality refactor they'll HAVE to merge it

@Lutowski
Copy link
Collaborator

Lutowski commented Jan 2, 2025

oh whatever

@Lutowski Lutowski merged commit 64a8087 into GeneralPantsuIsBadAtCoding:main Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants