Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor routes & helpers #239

Merged
merged 7 commits into from
Aug 11, 2023
Merged

Conversation

florent-uzio
Copy link
Contributor

This PR refactors the Routes to make it more flexible and readable.

It also adds some helpers to:

  • Easily inject a path parameter in a URL (+ tests)
  • Identify if a const is a string, number, object, function... (+ tests)

GemWallet still works as usual:

2023-08-11_19-15-05.mp4

@FlorianBouron
Copy link
Collaborator

@all-contributors add @florent-uzio for code

@allcontributors
Copy link
Contributor

@FlorianBouron

I've put up a pull request to add @florent-uzio! 🎉

@FlorianBouron
Copy link
Collaborator

Thank you so much for your contribution, it seems ready to merge.
Though could you please remove the unused constant within App.tsx, here is the link to the failing pipeline: https://github.com/GemWallet/gemwallet-extension/actions/runs/5835263193/job/15827483774?pr=239

Copy link
Collaborator

@FlorianBouron FlorianBouron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the following comment above

@ThibautBremand ThibautBremand changed the title Refactoring Routes + helpers Refactor Routes & helpers Aug 11, 2023
@ThibautBremand ThibautBremand changed the title Refactor Routes & helpers Refactor routes & helpers Aug 11, 2023
@ThibautBremand
Copy link
Collaborator

Thanks a lot @florent-uzio 👍

@FlorianBouron FlorianBouron merged commit 69c5441 into GemWallet:master Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants