New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display NFTs #143

Merged

ThibautBremand merged 47 commits into master from nft-listing

Aug 14, 2023

Collaborator

TusharPardhe commented Apr 18, 2023

This MR adds

NFT displaying functionality
View Button to redirect to NFT details
Lazy loading of images
Infinite scrolling for NFT listings

TusharPardhe commented

View reviewed changes

packages/extension/src/contexts/LedgerContext/LedgerContext.tsx Outdated Show resolved Hide resolved

FlorianBouron reviewed

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

Collaborator

FlorianBouron commented Apr 20, 2023

Could you please rebase your branch instead of merging from master? This is creating a cleaner git history.
I have cherry-picked your commits to clean up the git-history, please pull the branch again before making changes, the git history has been changed.

Collaborator

FlorianBouron commented Apr 20, 2023

The cypress tests are failing on the pipeline, could you please make them pass?
Also you will need to check that the NFT viewer feature is fully passing with cypress to make sure we do not have any regressions in the future :)

FlorianBouron force-pushed the nft-listing branch from d3447ea to b675099 Compare

April 20, 2023 06:40

FlorianBouron reviewed

View reviewed changes

packages/extension/package.json Outdated Show resolved Hide resolved

packages/extension/src/contexts/LedgerContext/LedgerContext.tsx Outdated Show resolved Hide resolved

FlorianBouron reviewed

View reviewed changes

packages/constants/src/payload/payload.types.ts Outdated Show resolved Hide resolved

FlorianBouron reviewed

View reviewed changes

packages/extension/src/contexts/LedgerContext/LedgerContext.tsx Outdated Show resolved Hide resolved

FlorianBouron reviewed

View reviewed changes

packages/extension/src/components/pages/Nfts/Nfts.tsx Outdated Show resolved Hide resolved

FlorianBouron reviewed

View reviewed changes

packages/extension/src/components/pages/Nfts/Nfts.tsx Outdated Show resolved Hide resolved

FlorianBouron self-assigned this

FlorianBouron added the enhancement label

FlorianBouron reviewed

View reviewed changes

packages/extension/src/components/organisms/NftListing/NftListing.tsx Outdated Show resolved Hide resolved

FlorianBouron reviewed

View reviewed changes

packages/extension/src/contexts/LedgerContext/LedgerContext.tsx Outdated Show resolved Hide resolved

TusharPardhe force-pushed the nft-listing branch from b675099 to d3447ea Compare

April 30, 2023 16:21

ThibautBremand force-pushed the nft-listing branch 4 times, most recently from 811f711 to 69f7097 Compare

June 28, 2023 07:50

ThibautBremand changed the title ~~Nft-listing~~ NFT listing

ThibautBremand changed the title ~~NFT listing~~ List NFTs

ThibautBremand changed the title ~~List NFTs~~ Display NFTs

ThibautBremand force-pushed the nft-listing branch from 69f7097 to 7685127 Compare

June 28, 2023 07:55

ThibautBremand marked this pull request as draft

June 28, 2023 09:06

ThibautBremand force-pushed the nft-listing branch 6 times, most recently from 1d64c5a to 71a135a Compare

June 28, 2023 17:13

FlorianBouron and others added 12 commits

August 13, 2023 19:04


          Cleaning up code

20bf669


          Fix post review

71cb8fd


          Simplify formatStringToBeDisplayed function

6fc5ad5


          Add post review changes

3fdebd6


          Wrap fetchNFTs into useCallback

630dac3


          Fix typing in NFTCard.test.tsx

c24a230


          Extract NFT parts into dedicated components

97c7ec0


          Change code post review

ee14815


          Introduce TruncatedText component

c5f274c


          Fix post rebase

b88e058


          Handle parsing of XLS-24 standard

c6e49a1


          Fix unit tests

ThibautBremand force-pushed the nft-listing branch from f5bc556 to 6611661 Compare

August 13, 2023 17:04


          Refactor TruncatedText & introduce TruncatedMultiLinesText components

2721b72

ThibautBremand force-pushed the nft-listing branch from 9260e42 to 2721b72 Compare

August 13, 2023 18:25

florent-uzio reviewed

View reviewed changes

packages/extension/src/components/atoms/TruncatedMultiLinesText/TruncatedMultiLinesText.tsx Outdated Show resolved Hide resolved

florent-uzio reviewed

View reviewed changes

packages/extension/src/components/atoms/TruncatedText/TruncatedText.tsx Outdated Show resolved Hide resolved

packages/extension/src/components/atoms/TruncatedText/TruncatedText.tsx Outdated Show resolved Hide resolved

packages/extension/src/components/organisms/NFTDetails/NFTDetails.tsx Outdated Show resolved Hide resolved

ThibautBremand and others added 5 commits

August 14, 2023 09:45


          Rework TruncatedText and TruncatedMultiLinesText components

ae7e64c


          Remove NFTListItem component

207f171


          Refactor TruncatedText component

0139fd5


          Fix code post review

f7f5859


          Refactor TruncatedText

dc53022

FlorianBouron force-pushed the nft-listing branch 3 times, most recently from f4997ac to 4dbf7a8 Compare

August 14, 2023 20:01


          Edit default NFT image

d71769c

FlorianBouron force-pushed the nft-listing branch from 4dbf7a8 to d71769c Compare

August 14, 2023 20:24

FlorianBouron approved these changes

View reviewed changes

ThibautBremand merged commit 4215764 into master

3 checks passed

ThibautBremand deleted the nft-listing branch

August 14, 2023 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels