Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to allow customising radial track labels #246

Closed
wants to merge 4 commits into from

Conversation

LudoPL
Copy link
Contributor

@LudoPL LudoPL commented Aug 9, 2023

This is a PR to implement this feature : #245
Don't hesitate to modify it as you want.

Copy link
Contributor

@hasnentai hasnentai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add screen shot or something which can demonstrate this feature ?

@@ -121,6 +122,11 @@ class RadialTrack {
/// The [trackStyle] property is used to customize the track of the Radial Gauge.
///
final TrackStyle trackStyle;

///
/// The [mapTrackLabel] property is used to customize the track labels of the Radial Gauge.
Copy link
Contributor

@hasnentai hasnentai Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an example code here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reactivity. I add some example here, in the example directory and a screenshot in the README.

@LudoPL
Copy link
Contributor Author

LudoPL commented Aug 9, 2023

Can you also please add screen shot or something which can demonstrate this feature ?

image

@LudoPL LudoPL requested a review from hasnentai August 9, 2023 15:29
@LudoPL
Copy link
Contributor Author

LudoPL commented Aug 10, 2023

Sorry, I will close this pull request because I have done it from the "main" branch of my repo.
I will reopen it with a different source branch : #248

@LudoPL LudoPL closed this Aug 10, 2023
@LudoPL LudoPL mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants