fix: code coverage work with poetry and add coverage.json gitignore #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannahb09 I approved the checks to run for the PR and they are currently failing; I recommend looking into solving these issues. |
This PR looks good, but make sure the linting checks and tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Code Coverage
##description
This PR fixes an issue with the code coverage and poetry. Gatorgrader code coverage commands were made before poetry was added to it. As a result I updated the pyproject.toml so that code coverage can work with poetry and not from a script folder. I also fix so that the percent is giving to us is for the gator files and not the test files. Additionally I have it so the coverage.json file is in the gitignore now so that it is ignored. To run this pr you can use the command
poetry run task test. The run is very long so to know you got the right output 870 tests need to be passed. Another command that needs to be run ispoetry run task coverageThis PR has: