Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add integration testing support #220

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

simojo
Copy link
Collaborator

@simojo simojo commented Oct 15, 2020

This PR is a feature that fixes #197. This PR provides support for integration testing of sample/starter repositories under Gator Educator.

Simply put, this feature will halt the build process if gradle grade shows any inconsistency (i.e. it passes starter repositories and fails solutions). For a technical description, see code.

@gkapfham please note that there exist gaps to fill, tests to write, and that this code has not yet been tested using gradle. Due to what hinders us to meet in person, I hope this PR will provide enough context for the time being.

@gkapfham
Copy link
Collaborator

Hello @simojo can you please provide documentation about how to run this code?

@simojo
Copy link
Collaborator Author

simojo commented Dec 1, 2020

@gkapfham I believe the only build errors left are ones pertaining to the ruby package manager and other files I did not touch!

@simojo simojo force-pushed the feature/integration-testing branch from 57a726a to d09ca2e Compare January 14, 2021 04:45
@simojo
Copy link
Collaborator Author

simojo commented Jan 14, 2021

for python proc management

https://docs.python.org/3/library/os.html#process-management

@simojo simojo force-pushed the feature/integration-testing branch from d09ca2e to 57a726a Compare January 14, 2021 18:08
@corlettim
Copy link
Collaborator

Hi @simojo ! I am just reaching out to see if you need any help with working on this PR during this semester. If so, please let me or anyone else on the GatorGrader team! We would be happy to help. I see that your PR is out of date with master so if you are able to update it, it would let us see if the errors still exist and we can go from there.
We also have weekly meetings on Wednesday and if you would like to join, please let me know and we can set you up with the info. Thanks!

@simojo
Copy link
Collaborator Author

simojo commented Mar 17, 2021

Hi @corlettim! Thanks for the message. I'll fast forward the branch to be even with master, thanks for reminding me.

@simojo simojo force-pushed the feature/integration-testing branch from bdccec1 to be1febb Compare March 18, 2021 02:34
@simojo simojo force-pushed the feature/integration-testing branch from be1febb to 6e7f55b Compare March 18, 2021 02:50
@simojo
Copy link
Collaborator Author

simojo commented Mar 18, 2021

Alright, @corlettim, it's rebased on top of the upstream master! Feel free to review it; the functionality is there, but there may be minor wrinkles in the semantics. It essentially clones down every solution and starter repo and grades both of them, ensuring that the starters fail and the solutions pass.

@corlettim
Copy link
Collaborator

corlettim commented Mar 18, 2021

Alright, @corlettim, it's rebased on top of the upstream master! Feel free to review it; the functionality is there, but there may be minor wrinkles in the semantics. It essentially clones down every solution and starter repo and grades both of them, ensuring that the starters fail and the solutions pass.

Awesome! also sorry about momentarily closing it lol...clicked the wrong button. But I will definitely take a look at it. Thanks again for getting it up to date!

@corlettim corlettim closed this Mar 18, 2021
@corlettim corlettim reopened this Mar 18, 2021
@corlettim
Copy link
Collaborator

Hey @simojo ! We are made some changes in the master branch by updating the dependencies so please make sure to resolve the conflicts you are currently having with your PR. Also, when you get the chance, if you could give us an update on what your next steps are with this PR so the software engineering team can help in anyway possible.

simojo added 2 commits April 1, 2021 09:01
It will be better to leave self implemented coloring out because this will run on windows, mac, and possibly zsh; not only bash.
@simojo
Copy link
Collaborator Author

simojo commented Apr 2, 2021

Ideally, my next steps would be merge it. Apparently there is some linting error with invoking subprocesses without a shell; does your team have a specific way you approach invoking shell commands via python? I don't think security is really that big of an issue here, but the linter says otherwise.

@simojo
Copy link
Collaborator Author

simojo commented Jun 17, 2021

Are there any plans to merge this any time soon?

@gkapfham gkapfham added automation on-hold This PR or issue may be handled in the future labels Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation on-hold This PR or issue may be handled in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration testing support that uses the sample repositories
3 participants