-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional weighted checks #161
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of concerns that I bring up in my comments; it's very possible that I'm simply missing something obvious, hence my request for clarification on these.
…ensure coverage is maintained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me on my Linux computer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weight Feature
Description
This feature allows instructors to add weights that will be calculated and displayed for checks. The weights can be added under options in the gatorgrade.yml file. This will be very beneficial because it provides instructors with an opportunity to weight more important checks.
Linked Issues
(closes: #143)
Type of Change
Contributors
@dyga01
@TitusSmith33
Images
*Note: test_parse_config_check_gg_matchfilefragment() was deleted to ensure this PR has a passing build. This test case may be able to be updated to reflect the updated feature, but I have not explored that yet.