Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional weighted checks #161

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

dyga01
Copy link
Collaborator

@dyga01 dyga01 commented Nov 22, 2024

Weight Feature

Description

This feature allows instructors to add weights that will be calculated and displayed for checks. The weights can be added under options in the gatorgrade.yml file. This will be very beneficial because it provides instructors with an opportunity to weight more important checks.

Linked Issues

(closes: #143)

Type of Change

  • Feature
  • Bug fix
  • Documentation

Contributors

@dyga01
@TitusSmith33

Images

Screenshot 2024-11-21 at 8 21 02 PM

*Note: test_parse_config_check_gg_matchfilefragment() was deleted to ensure this PR has a passing build. This test case may be able to be updated to reflect the updated feature, but I have not explored that yet.

dyga01 and others added 30 commits November 11, 2024 21:48
Copy link
Collaborator

@rebekahrudd rebekahrudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked on my Linux computer:
image

Copy link
Collaborator

@boulais01 boulais01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of concerns that I bring up in my comments; it's very possible that I'm simply missing something obvious, hence my request for clarification on these.

gatorgrade/output/output.py Outdated Show resolved Hide resolved
tests/input/test_input_gg_checks.py Outdated Show resolved Hide resolved
@dyga01 dyga01 requested a review from boulais01 December 6, 2024 04:44
@boulais01 boulais01 requested a review from rebekahrudd December 6, 2024 15:00
Copy link
Collaborator

@AlishChhetri AlishChhetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@rebekahrudd rebekahrudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me on my Linux computer!

@Chezka109 Chezka109 self-requested a review December 9, 2024 15:40
Copy link
Collaborator

@Chezka109 Chezka109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Mac:
Screenshot 2024-12-09 at 10 40 15 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Weighted GatorGrade Checks
6 participants