-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Bar Implementation #149
Open
TitusSmith33
wants to merge
4
commits into
GatorEducator:main
Choose a base branch
from
TitusSmith33:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar functionality in main.py
rebekahrudd
approved these changes
Oct 31, 2024
CalebKendra
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
AlishChhetri
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dyga01
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress Bar Implementation
Description
This PR introduced a progress bar into the
gatorgrade
that demonstrates some dynamic progress bar to the user. The base implementation -what is included when you run the commandgatorgrade
in your terminal- is a dynamic progress bar that updates a progress bar based on if a check passes or fails, while the checks are being run. If a check passes, the progress updates the green section of the bar and any failed checks remain red on the progress bar. Below is an image of the expected output for thegatorgrade
command, where as you can see some checks failed so that is represented in the progress bar:This is what the progress bar output should look like if all the checks pass:
If you run
gatorgrade --run_status_bar
the functionality of the progress bar changes. Instead of updating the dynamic progress bar based on whether the checks pass or fail, this progress bar updates dynamically based on whether agatorgrade
check runs or fails to run. This implementation is useful for debugging and more advanced uses ofgatorgrade
. Similarly to the default progress bar, the bar updates green if a check runs and any failed checks keep a section of the bar red. Below is an image of the expected output for thegatorgrade --run_status_bar
command, where as you can see some checks failed, however this progress bar is only concerned on if the checks run or not:Lastly, there is an implementation using the command
gatorgrade --no_status_bar
which disables all progress bars and simply produces the output fromgatorgrade
with no progress bar present. Below is an image of the expected output for thegatorgrade --no_status_bar
command, where there is no progress bar at all:The implementation for this feature are in
output.py
in therun_checks
functions, and the flags update for--run_status_bar
and--no_status_bar
are inmain.py
. I have run and tested this on a Windows 11 OS and would love to have another OS review this PR to ensure the feature is compatible across different OS. Thank you!!Type of Change
Contributors