-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: produce output when commands/checks are executed #53
base: main
Are you sure you want to change the base?
Conversation
Hello @hemanialaparthi I noticed that there are problems with the build for this PR on Windows. Can you please investigate this further and try to resolve the problem? If there is a problem with something in GitHub Actions on Windows perhaps you could reach out to @PCain02 or Molly or others who are doing development on Windows and see what fails in GitHub Actions and then see if it also fails when they run it locally? Thanks for investigating this further! |
Finally, @hemanialaparthi, once this PR is finalized, please let me know so that I can mark that it is ready for review and thus no longer a draft. Overall, I think that the direction you are moving in for this PR is great --- hopefully we can finalize this and merge it soon! |
On it! I will discuss and figure out in lab to see why the build is failing on windows. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am on linux and i got the overall status x one or more checks failed. This pr looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes appear to be working on Mac Os. LGTM!
Produce Output When Executed
Modifying
execexam
to produce an output when executed.@hemanialaparthi
Returning output when execexam fails #42
bug
,enhancement
The goal of this pull request is to ensure that
execexam
provides meaningful output when it encounters a failure. Currently, the lack of output can mislead users into believing the program executed successfully, as silence is often interpreted as success.Coverage will be maintained as this update includes error handling tests to verify the new functionality.
Tested on macOS, would appreciate testing on
linux
&windows
Include a code block and/or screenshots displaying the functionality of your feature, if applicable/possible.
Before, when commands such as
poetry run execexam . tests/ --mark "question_one_part_c" --fancy
(this command is from theexecutable-examination-example-solution
repository), there would be no output. This new feature produces an output as default when the commands are ran.