Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: produce output when commands/checks are executed #53

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

hemanialaparthi
Copy link
Collaborator

@hemanialaparthi hemanialaparthi commented Nov 19, 2024

Produce Output When Executed

  1. Modifying execexam to produce an output when executed.

  2. @hemanialaparthi

  3. Returning output when execexam fails #42

  4. bug, enhancement

  5. The goal of this pull request is to ensure that execexam provides meaningful output when it encounters a failure. Currently, the lack of output can mislead users into believing the program executed successfully, as silence is often interpreted as success.

  6. Coverage will be maintained as this update includes error handling tests to verify the new functionality.

  7. Tested on macOS, would appreciate testing on linux & windows

  8. Include a code block and/or screenshots displaying the functionality of your feature, if applicable/possible.

Before, when commands such as poetry run execexam . tests/ --mark "question_one_part_c" --fancy (this command is from the executable-examination-example-solution repository), there would be no output. This new feature produces an output as default when the commands are ran.
image
image

@hemanialaparthi hemanialaparthi added the bug Something isn't working label Nov 19, 2024
@gkapfham
Copy link
Collaborator

Hello @hemanialaparthi I noticed that there are problems with the build for this PR on Windows. Can you please investigate this further and try to resolve the problem? If there is a problem with something in GitHub Actions on Windows perhaps you could reach out to @PCain02 or Molly or others who are doing development on Windows and see what fails in GitHub Actions and then see if it also fails when they run it locally? Thanks for investigating this further!

@gkapfham
Copy link
Collaborator

gkapfham commented Nov 20, 2024

Finally, @hemanialaparthi, once this PR is finalized, please let me know so that I can mark that it is ready for review and thus no longer a draft. Overall, I think that the direction you are moving in for this PR is great --- hopefully we can finalize this and merge it soon!

@hemanialaparthi
Copy link
Collaborator Author

hemanialaparthi commented Nov 21, 2024

Hello @hemanialaparthi I noticed that there are problems with the build for this PR on Windows. Can you please investigate this further and try to resolve the problem? If there is a problem with something in GitHub Actions on Windows perhaps you could reach out to @PCain02 or Molly or others who are doing development on Windows and see what fails in GitHub Actions and then see if it also fails when they run it locally? Thanks for investigating this further!

On it! I will discuss and figure out in lab to see why the build is failing on windows. Thanks!

@hemanialaparthi hemanialaparthi marked this pull request as ready for review December 5, 2024 20:56
Copy link
Collaborator

@CalebKendra CalebKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hannahb09 hannahb09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on linux and i got the overall status x one or more checks failed. This pr looks good to me

@dyga01 dyga01 self-requested a review December 9, 2024 13:36
Copy link
Collaborator

@dyga01 dyga01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes appear to be working on Mac Os. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants