Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Issue Templates to be Selectable on GitHub #43

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

PCain02
Copy link
Collaborator

@PCain02 PCain02 commented Nov 5, 2024

Issue templates are currently not selectable. Now it should be a popup when you go to make a new issue you can select from the choices.

  1. List the names of those who contributed to the project.
    @PCain02

  2. Link the issue the pull request is meant to fix/resolve.
    Issue Templates are not Selectable #44

  3. Describe the contents and goal of the pull request.
    This PR adds the ability to select an issue template when going to make an issue. The choices are bug, feature, or custom.

  4. What operating systems has this been tested on? How were these tests conducted?

This is a feature on GitHub so it does not really apply but I am on Windows 10

  1. Add all labels that apply. (e.g., documentation, ready-for-review)
    Infrastructure

  2. Will coverge be maintained/increased?
    This does not affect coverage.

  3. Include a code block and/or screenshots displaying the functionality of your
    feature, if applicable/possible.

@PCain02 PCain02 changed the title Update issue templates to be selectable feat: Update Issue Templates to be Selectable Nov 5, 2024
@PCain02 PCain02 changed the title feat: Update Issue Templates to be Selectable fix: Update Issue Templates to be Selectable Nov 5, 2024
@PCain02 PCain02 changed the title fix: Update Issue Templates to be Selectable fix: Update Issue Templates to be Selectable on GitHub Nov 5, 2024
Copy link
Collaborator

@rebekahrudd rebekahrudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Is there something we should test locally for this update?

@hannahb09 hannahb09 self-requested a review November 6, 2024 15:40
Copy link
Collaborator

@hannahb09 hannahb09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked at the changes looks good to me

@PCain02
Copy link
Collaborator Author

PCain02 commented Nov 6, 2024

Yeah you can't really test anything since this was a setting change on GitHub and it won't be active until there is approval. The only changes were the Markdown documents so it's a pretty safe PR.

@PCain02 PCain02 added bug Something isn't working infrastructure CI/CD configuration labels Nov 7, 2024
@AlishChhetri AlishChhetri self-requested a review November 7, 2024 20:07
Copy link
Collaborator

@AlishChhetri AlishChhetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boulais01 boulais01 self-requested a review November 8, 2024 15:13
Copy link
Collaborator

@boulais01 boulais01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only note is that the custom template is uncustomized, if that's intentional you're clear.

@PCain02
Copy link
Collaborator Author

PCain02 commented Nov 11, 2024

@gkapfham Can this get merged since I got all the approvals?

@PCain02
Copy link
Collaborator Author

PCain02 commented Nov 11, 2024

LGTM. Only note is that the custom template is uncustomized, if that's intentional you're clear.

Yep! I just wanted to leave that for people to make their own.

@AlishChhetri AlishChhetri merged commit baade64 into main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure CI/CD configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants