-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update Issue Templates to be Selectable on GitHub #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Is there something we should test locally for this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked at the changes looks good to me
Yeah you can't really test anything since this was a setting change on GitHub and it won't be active until there is approval. The only changes were the Markdown documents so it's a pretty safe PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only note is that the custom template is uncustomized, if that's intentional you're clear.
@gkapfham Can this get merged since I got all the approvals? |
Yep! I just wanted to leave that for people to make their own. |
Issue templates are currently not selectable. Now it should be a popup when you go to make a new issue you can select from the choices.
List the names of those who contributed to the project.
@PCain02
Link the issue the pull request is meant to fix/resolve.
Issue Templates are not Selectable #44
Describe the contents and goal of the pull request.
This PR adds the ability to select an issue template when going to make an issue. The choices are bug, feature, or custom.
What operating systems has this been tested on? How were these tests conducted?
This is a feature on GitHub so it does not really apply but I am on Windows 10
Add all labels that apply. (e.g., documentation, ready-for-review)
Infrastructure
Will coverge be maintained/increased?
This does not affect coverage.
Include a code block and/or screenshots displaying the functionality of your
feature, if applicable/possible.