-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Error Handling for Missing Internet Connection #20
Closed
hemanialaparthi
wants to merge
52
commits into
GatorEducator:main
from
PCain02:handle_internet_connection
Closed
feat: Add Error Handling for Missing Internet Connection #20
hemanialaparthi
wants to merge
52
commits into
GatorEducator:main
from
PCain02:handle_internet_connection
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checking, python support, and dependency install
…into PyPI-automation
feat: Automatic PyPI Publishing using Tags
hemanialaparthi
added
bug
Something isn't working
enhancement
New feature or request
labels
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Add Error Handling for Missing Internet Connection and ensure CodingMentor doesn't crash.
List the names of those who contributed to the project.
@hemanialaparthi
Link the issue the pull request is meant to fix/resolve.
Closes Bug: Litellm Requires Internet Connection #15
Describe the contents and goal of the pull request.
This PR adds a feature that improves how the program handles situations where there is no internet connection. Previously, the program would crash if the Litellm dependency couldn't connect to the internet. Now, the program checks for an internet connection before running. If no connection is found, the user receives a message asking them to check their network, preventing the program from crashing and making it more reliable in offline situations.
Will coverge be maintained/increased?
Yes, coverage will be increased for the advice module, as I have implemented new tests to ensure the new feature is fully tested.
What operating systems has this been tested on? How were these tests conducted?
The tests have been conducted on a mac. It would be great if I could have a Linux and Windows user test it out.
Include a code block and/or screenshots displaying the functionality of your
feature, if applicable/possible.
When the coding mentor is run without internet this should be included in the output:
If internet connection is present, the program will continue and no additional output is produced.
Mark as a draft until it is ready to begin the reviewing process and then tag
Gregory Kapfhammer when you mark it as ready
for review.