-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: README Badges and Execexam Logo #19
Conversation
…checking, python support, and dependency install
…into PyPI-automation
@PCain02, so for now the badges update when the command |
@PCain02 @Chezka109 Hello, do we think this this wait to be merged until after the version updating PR is complete(PR #18 ), or before? The version updating is waiting on a test from a Mac user. |
@boulais01, I have just tested PR #18 on a Mac and can confirm it works. Since there is a version tag, it would make more sense for PR #18 to be complete. @PCain02, how does that sound to you? After it has been merged, I can update the version badge as well to reflect the updates. |
Sounds good to me! I will say the version badge should be based on the actual version which I believe is 0.3.0 and not on the test version is which is like 0.3.39. So make sure it reflects the actual version number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo looks great, and I'm glad to see #e5e5e5 getting some love! Overall, this LGTM, but I would recommend waiting to merge this PR until the python badges.py
command can be incorporated into GitHub Actions and fully automated. This will ensure that badges are updated seamlessly without manual intervention, aligning with the team's long-term goal of automating these processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Chezka109, this PR is making strong improvements in a positive direction, thanks for creating it. However, we can't merge this PR if it creates the badges.py
file in the main directory of the project. Generally, we avoid creating Python source code files in the main project directory that is reserved for configuration files and the README.md
file. Can you please consider moving the aforementioned Python script to, for instance, a scripts
directory?
Also, why is there a need for a separate ci.yml
file. Why can't this go in the main build.yml
file.
Finally, please note that this PR is likely going to be merged after the PR that sets up publishing to PyPI. You will need to make sure that you merge in all of those changes so that we don't delete/modify any configurations that have already been approved and merged into the main
branch of the tool.
@gkapfham the changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Chezka109, if this PR is only about badges and the logo, then why are there so many commits not connected to these two elements? Also, please note that your build is failing and thus no members of our team are going to commit the time and resources to reviewing your PR. |
Hello @Chezka109 this PR has a failing build. Do you plan to move forward with it or should we close it because you do not plan to resolve the build and move forward with this documentation feature? |
Hello @Chezka109 can this PR be closed? |
Pull Request: Add Dynamic Badges and Create Logo for
execexam
Contributors:
Linked Issue:
Labels:
enhancement
infrastructure
Description:
This pull request introduces two key updates to the
execexam
project:Dynamic Badges:
Project Logo:
execexam
to improve project branding and visibility. The logo will be displayed prominently in the repository’s README file.Coverage:
Testing:
Screenshots:
Dynamic Coverage Badge:
New Project Logo: