Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme #37

Merged
merged 15 commits into from
Dec 12, 2023
Merged

Readme #37

merged 15 commits into from
Dec 12, 2023

Conversation

EvanNelson04
Copy link
Collaborator

Readme update looking for review

@hayleepierce hayleepierce added documentation Improvements or additions to documentation in-progress This pull request is in progress. labels Nov 28, 2023
@hayleepierce hayleepierce linked an issue Nov 28, 2023 that may be closed by this pull request
@EvanNelson04 EvanNelson04 added ready-for-review This pull request is ready for review. and removed in-progress This pull request is in progress. labels Dec 5, 2023
Copy link
Collaborator

@hayleepierce hayleepierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good base README.md. We can continue to add to this as we go. Thank you!

@hayleepierce hayleepierce self-requested a review December 5, 2023 20:04
Copy link
Collaborator

@jnormile jnormile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting a README together! I think there's still room to tighten up the documentation--please refer to my comments for opportunities to bring this closer to a professional quality!


## ⚡️ Requirements

- Cellveyor git hub repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little nit-picky, but given that we're aiming to produce software that presents as professional-quality, it's worth noting that it should be GitHub (proper noun, one word).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
## 🎉 Introduction

- Cellveyor is a python program that produces assignment reports for students or
classes. Using cellveyor will publicly give grade reports including feedback for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent with the casing for Cellveyor (either always all lowercase, or always have the "C" capitalized).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I reviewed that and fixed all of it

README.md Outdated
created, this will quickly and automatically send out these reports in a very timely
and efficient fashion.

## 😂 Definitions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I see what you're going for based on the chasten repository, I'm not sure a "Definitions" section is really warranted. "Cellveyor" isn't necessarily a real word (like chasten); instead, if you're interested in a section like this, re-tool it to give some explanation behind the tool's name.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the definition of cellveyor a bit, could I use the sentence usage part?

@hayleepierce hayleepierce requested a review from jnormile December 5, 2023 20:53
Copy link
Collaborator

@jnormile jnormile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this content together, and quickly implementing feedback! It looks good!

@wolff01 wolff01 self-requested a review December 8, 2023 19:38
Copy link
Collaborator

@wolff01 wolff01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. This is a huge contribution to the cellveyor program thank you.

@jnormile jnormile merged commit b3e7b35 into GatorEducator:master Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready-for-review This pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadMe Update
5 participants