-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme #37
Readme #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good base README.md. We can continue to add to this as we go. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting a README together! I think there's still room to tighten up the documentation--please refer to my comments for opportunities to bring this closer to a professional quality!
|
||
## ⚡️ Requirements | ||
|
||
- Cellveyor git hub repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little nit-picky, but given that we're aiming to produce software that presents as professional-quality, it's worth noting that it should be GitHub (proper noun, one word).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
README.md
Outdated
## 🎉 Introduction | ||
|
||
- Cellveyor is a python program that produces assignment reports for students or | ||
classes. Using cellveyor will publicly give grade reports including feedback for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consistent with the casing for Cellveyor (either always all lowercase, or always have the "C" capitalized).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I reviewed that and fixed all of it
README.md
Outdated
created, this will quickly and automatically send out these reports in a very timely | ||
and efficient fashion. | ||
|
||
## 😂 Definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I see what you're going for based on the chasten
repository, I'm not sure a "Definitions" section is really warranted. "Cellveyor" isn't necessarily a real word (like chasten); instead, if you're interested in a section like this, re-tool it to give some explanation behind the tool's name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the definition of cellveyor a bit, could I use the sentence usage part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this content together, and quickly implementing feedback! It looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. This is a huge contribution to the cellveyor program thank you.
Readme update looking for review