Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade dependency-review-action to version 4.3.3 #792

Merged

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Aug 14, 2024

Description of the Change

Following the description at actions/dependency-review-action#809 (comment)

Version 4.3.4 does not work with invalid license names in the config and since that version,
SPDX expression licenses are considered invalid (see: actions/dependency-review-action#792).

In short, remove all SPDX expressions from the config!
Note that if you have packages that use SPDX expressions, this will report them as invalid,
as support is not yet implemented (see: actions/dependency-review-action#263).

In that case you need to downgrade to version 4.3.3 where SPDX expressions are handled as exact strings !!

Closes # Hopefully fixes the failing GitHub workflow run on invalid licenses, that aren't invalid in reality.

How to test the Change

Changelog Entry

Changed - Downgrade version of dependency-review-action to prevent false-positives.

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mauteri mauteri merged commit 48a8e2d into GatherPress:main Aug 14, 2024
6 checks passed
@carstingaxion carstingaxion mentioned this pull request Aug 25, 2024
4 tasks
- name: Dependency Review
uses: actions/dependency-review-action@v4
uses: actions/dependency-review-action@72eb03d02c7872a771aacd928f3123ac62ad6d3a # Version 4.3.3 # https://github.com/actions/dependency-review-action/releases/tag/v4.3.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you didn't change to actions/[email protected]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants