Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/calamares i18n #101

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Babilinx
Copy link

Internationalize the branding and package description.

The Calamares documentation has been followed closely but nothing was tested as i don't have a Nix environement.

@Babilinx Babilinx mentioned this pull request Dec 24, 2024
@CORAAL CORAAL self-requested a review December 25, 2024 10:09
@CORAAL CORAAL self-assigned this Dec 25, 2024
@CORAAL CORAAL added the enhancement New feature or request label Dec 25, 2024
@CORAAL CORAAL added this to the Next Release milestone Dec 25, 2024
Copy link
Contributor

@CORAAL CORAAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swappy-20241225-124844
swappy-20241225-124852

Merci pour les PR :)

Malheureusement, les traductions n'apparaîssent pas.
J'ai testé localement en "fusionnant" une branche de test qui inclut les PR #101 et #102 mais la langue d'affichage (voir screen) reste sur l'anglais bien que le reste de l'interface soit bien en français.

Note

Le fichier ajouté dans flake.nix (celui qui est copié ensuite dans calamares) apparaît bien dans l'arborescence du paquet compilé.

@Babilinx
Copy link
Author

Ah zut.
Je n'ai jamais fait ça avec QT, donc il fallait bien que ça foire. Après avoir relu la doc, il semblerait qu'il fasse compiler les .ts. Je vais donc regarder ça demain et mettre à jour #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Review 👀
Development

Successfully merging this pull request may close these issues.

2 participants