Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hldmserver): add support for the fastdl command #4472

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Flambe
Copy link

@Flambe Flambe commented Jan 27, 2024

Description

This allows the fastdl command to be used on hldm servers. It also disables bzip2 compression for hldm as these servers do not support downloading the compressed files.

Fixes #4471

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

GameServerManagers/LinuxGSM-Docs#100

Thank you for your Pull Request!

@Flambe
Copy link
Author

Flambe commented Jan 27, 2024

The static code analysis fails on the second half of the echo which I haven't touched, so I do not believe that this is related to my PR? $(fn_human_readable_file_size ${filesizetotal} 0)

If I'm wrong or you want it fixed regardless, I can push a fix up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant