Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new server): Counter Strike 2 #4356

Merged
merged 27 commits into from
Oct 27, 2023
Merged

feat(new server): Counter Strike 2 #4356

merged 27 commits into from
Oct 27, 2023

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Oct 27, 2023 •
edited
Loading

Description

Counter-Strike 2

Fixes #4330

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 15 commits October 27, 2023 15:36
@dgibbs64
cs2
55d3062
@dgibbs64
config
78093c3
@dgibbs64
fix: remove lo code
b16bf70
@dgibbs64
config
9d7bfe7
@dgibbs64
params
e8d2e48
@dgibbs64
source2
e208d91
@dgibbs64
game info
abff04d
@dgibbs64
messages
e3e4667
@dgibbs64
config changes
5dfe4c7
@dgibbs64
dirs
2dfe71a
@dgibbs64
config
75006b2
@dgibbs64
refactor: refactor info message functions in alert.sh, command_detail…
3142025 
…s.sh, command_dev_query_raw.sh, and command_postdetails.sh

- Refactored the info message functions in multiple files to have consistent naming conventions.
- Renamed fn_info_message_* functions to fn_info_messages_* for clarity and consistency.
- Updated function calls accordingly.
@dgibbs64
refactor: remove unnecessary code duplication in info_game.sh
03d44e5 
The commit removes duplicated code for retrieving server information from the game configuration file. Specifically, it removes redundant lines related to rconpassword, rconport, and serverpassword. This improves code readability and maintainability.
@dgibbs64
cs2
fec79ad
@dgibbs64
cs2
2067585
@dgibbs64 dgibbs64 linked an issue Oct 27, 2023 that may be closed by this pull request
[Server Request]: Counter Strike 2 #4322
Closed
2 tasks
@dgibbs64 dgibbs64 added this to the v23.6.0 milestone Oct 27, 2023
@dgibbs64 dgibbs64 merged commit f33bfdf into develop Oct 27, 2023
4 of 93 checks passed
@dgibbs64 dgibbs64 deleted the feature/4322-cs2 branch October 27, 2023 22:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.6.0
Development

Successfully merging this pull request may close these issues.

[Server Request]: Counter Strike 2
1 participant
@dgibbs64