Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(command) adds a command to place the systemd service file in the right location #3125

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

feat(command) adds a command to place the systemd service file in the right location #3125

wants to merge 36 commits into from

Conversation

legendofmiracles
Copy link

@legendofmiracles legendofmiracles commented Dec 11, 2020 •
edited
Loading

This PR adds a command to generate a systemd service file and places it in the /etc/systemd/system, so that the user can easily enable a gameserver upon boot, without having to write his/her own service file.

Why only systemd?

Because all the official supported distros use systemd and most distros in general as well.
If people request other init systems, i'd glady add support for those aswell.

  • New feature (change which adds functionality).

Checklist

  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

EDIT: I opened a Pull request:
GameServerManagers/LinuxGSM-Docs#54

Showcase

(the last information text, prints "the game" instead of this)
image

@h3o66 h3o66 linked an issue Dec 22, 2020 that may be closed by this pull request
systemd auto install #2145
Open
@h3o66
Copy link
Member

h3o66 commented Dec 22, 2020 •
edited by unfurl-links bot
Loading

Maybe you could squash/rebase the commits to one and do a commit title that matches the "Semantic Pull Request" standard.
More info can be find in the dev docs:
https://dev-docs.linuxgsm.com/getting-started/branching#pull-requests

@legendofmiracles
Copy link
Author

Is this better?

@h3o66
Copy link
Member

h3o66 commented Dec 22, 2020

Is this better?

looks good to me

unknowntrojan and others added 6 commits December 25, 2020 14:13
@unknowntrojan
fix(stop) stop will clear tmux text before entering stop command (Gam…
05e236f 
…eServerManagers#3142)

Tmux will ENTER before using stop command to clear any text entered in teh console
@h3o66 @dgibbs64
fix(update): redo steamcmd update part for new behavoir (GameServerMa…
dc6b037 
…nagers#3139)

Co-authored-by: Daniel Gibbs <[email protected]>
@h3o66 @dgibbs64
fix(bmdm): add missing dependency ncurses libs (GameServerManagers#3138)
55b3bbe 
Co-authored-by: Daniel Gibbs <[email protected]>
@h3o66
fix(minecraft): fix java ram assignment (GameServerManagers#3147)
5d58dcf
@dgibbs64
feat(config): add secrets config to store sensitive settings (GameSer…
d0ecddf 
…verManagers#3080)

* feat(config): add secrets.cfg

* changed name of config

* updated wording
@h3o66
feat(newserver): Colony Survival (GameServerManagers#3075)
9a85063
h3o66
h3o66 requested changes Dec 30, 2020
View reviewed changes
lgsm/functions/command_install_init.sh Outdated Show resolved Hide resolved
@h3o66 h3o66 requested a review from dgibbs64 December 30, 2020 12:21
@legendofmiracles legendofmiracles changed the title (command) adds a command to place the systemd service file in the right location feat(command) adds a command to place the systemd service file in the right location Dec 30, 2020
h3o66
h3o66 reviewed Dec 30, 2020
View reviewed changes
Copy link
Member

@h3o66 h3o66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

dgibbs64 and others added 3 commits December 30, 2020 23:33
@dgibbs64
feat(skeleton): New command skeleton (GameServerManagers#3152)
efa159d 
* initial commit of skel

* getopt

* getopt

* getopt

* cpio

* adding messages

* exit

* message

* shellcheck

* truncate netstat for colserver

* added cpio dependency

* tabs
@h3o66
feat(check-update): add new command check-update for steamcmd game se…
a075300 
…rvers (GameServerManagers#3146)
@legendofmiracles
replace the file with /usr/lib/ with /etc/
bf292f8
@legendofmiracles
Copy link
Author

I added documentation: GameServerManagers/LinuxGSM-Docs#54

@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:develop January 27, 2021 20:51
@h3o66 h3o66 reopened this Jan 28, 2021
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Jan 28, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2022
@dgibbs64 dgibbs64 reopened this Apr 21, 2022
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from f02e53d to 2257be4 Compare October 22, 2022 21:53
@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from 891ed8f to ca184e3 Compare September 7, 2023 20:23
@dgibbs64 dgibbs64 force-pushed the develop branch 2 times, most recently from 7a72c04 to f28a4e5 Compare December 3, 2023 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@h3o66 h3o66 h3o66 requested changes

@dgibbs64 dgibbs64 dgibbs64 requested changes

Assignees
No one assigned
Labels
branch conflicts Branch of pr has conflicts that need to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

systemd auto install
4 participants
@legendofmiracles @h3o66 @dgibbs64 @unknowntrojan